9931f7d5d2
the Intel kbuild bot reports a link failure when IOSF_MBI is built-in
but the Merrifield driver is configured as a module. The
soc-intel-quirks.h is included for Merrifield platforms, but IOSF_MBI
is not selected for that platform.
ld.lld: error: undefined symbol: iosf_mbi_read
>>> referenced by atom.c
>>> sound/soc/sof/intel/atom.o:(atom_machine_select) in archive vmlinux.a
This patch forces the use of the fallback static inline when IOSF_MBI is not reachable.
Fixes: 536cfd2f37 ("ASoC: Intel: use common helpers to detect CPUs")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202407160704.zpdhJ8da-lkp@intel.com/
Suggested-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://patch.msgid.link/20240722083002.10800-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
99 lines
2.3 KiB
C
99 lines
2.3 KiB
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
/*
|
|
* soc-intel-quirks.h - prototypes for quirk autodetection
|
|
*
|
|
* Copyright (c) 2019, Intel Corporation.
|
|
*
|
|
*/
|
|
|
|
#ifndef _SND_SOC_INTEL_QUIRKS_H
|
|
#define _SND_SOC_INTEL_QUIRKS_H
|
|
|
|
#include <linux/platform_data/x86/soc.h>
|
|
|
|
#if IS_REACHABLE(CONFIG_IOSF_MBI)
|
|
|
|
#include <linux/dmi.h>
|
|
#include <asm/iosf_mbi.h>
|
|
|
|
static inline bool soc_intel_is_byt_cr(struct platform_device *pdev)
|
|
{
|
|
/*
|
|
* List of systems which:
|
|
* 1. Use a non CR version of the Bay Trail SoC
|
|
* 2. Contain at least 6 interrupt resources so that the
|
|
* platform_get_resource(pdev, IORESOURCE_IRQ, 5) check below
|
|
* succeeds
|
|
* 3. Despite 1. and 2. still have their IPC IRQ at index 0 rather then 5
|
|
*
|
|
* This needs to be here so that it can be shared between the SST and
|
|
* SOF drivers. We rely on the compiler to optimize this out in files
|
|
* where soc_intel_is_byt_cr is not used.
|
|
*/
|
|
static const struct dmi_system_id force_bytcr_table[] = {
|
|
{ /* Lenovo Yoga Tablet 2 series */
|
|
.matches = {
|
|
DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
|
|
DMI_MATCH(DMI_PRODUCT_FAMILY, "YOGATablet2"),
|
|
},
|
|
},
|
|
{}
|
|
};
|
|
struct device *dev = &pdev->dev;
|
|
int status = 0;
|
|
|
|
if (!soc_intel_is_byt())
|
|
return false;
|
|
|
|
if (dmi_check_system(force_bytcr_table))
|
|
return true;
|
|
|
|
if (iosf_mbi_available()) {
|
|
u32 bios_status;
|
|
|
|
status = iosf_mbi_read(BT_MBI_UNIT_PMC, /* 0x04 PUNIT */
|
|
MBI_REG_READ, /* 0x10 */
|
|
0x006, /* BIOS_CONFIG */
|
|
&bios_status);
|
|
|
|
if (status) {
|
|
dev_err(dev, "could not read PUNIT BIOS_CONFIG\n");
|
|
} else {
|
|
/* bits 26:27 mirror PMIC options */
|
|
bios_status = (bios_status >> 26) & 3;
|
|
|
|
if (bios_status == 1 || bios_status == 3) {
|
|
dev_info(dev, "Detected Baytrail-CR platform\n");
|
|
return true;
|
|
}
|
|
|
|
dev_info(dev, "BYT-CR not detected\n");
|
|
}
|
|
} else {
|
|
dev_info(dev, "IOSF_MBI not available, no BYT-CR detection\n");
|
|
}
|
|
|
|
if (!platform_get_resource(pdev, IORESOURCE_IRQ, 5)) {
|
|
/*
|
|
* Some devices detected as BYT-T have only a single IRQ listed,
|
|
* causing platform_get_irq with index 5 to return -ENXIO.
|
|
* The correct IRQ in this case is at index 0, as on BYT-CR.
|
|
*/
|
|
dev_info(dev, "Falling back to Baytrail-CR platform\n");
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
#else
|
|
|
|
static inline bool soc_intel_is_byt_cr(struct platform_device *pdev)
|
|
{
|
|
return false;
|
|
}
|
|
|
|
#endif
|
|
|
|
#endif /* _SND_SOC_INTEL_QUIRKS_H */
|