8af2d2025d
Currently, there are two entries for CONFIG_GOLDFISH.
In arch/x86/Kconfig:
config GOLDFISH
def_bool y
depends on X86_GOLDFISH
In drivers/platform/goldfish/Kconfig:
menuconfig GOLDFISH
bool "Platform support for Goldfish virtual devices"
depends on HAS_IOMEM && HAS_DMA
While Kconfig allows multiple entries, it generally leads to tricky
code.
Prior to commit bd2f348db5 ("goldfish: refactor goldfish platform
configs"), CONFIG_GOLDFISH was an alias of CONFIG_X86_GOLDFISH.
After the mentioned commit added the second entry with a user prompt,
the former provides the 'default' property that is effective only when
X86_GOLDFISH=y.
Merge them tegether to clarify how it has worked in the past 8 years.
Cc: Greg Hackmann <ghackmann@google.com>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Link: https://lore.kernel.org/r/20240204081004.33871-1-masahiroy@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
21 lines
590 B
Plaintext
21 lines
590 B
Plaintext
# SPDX-License-Identifier: GPL-2.0-only
|
|
menuconfig GOLDFISH
|
|
bool "Platform support for Goldfish virtual devices"
|
|
depends on HAS_IOMEM && HAS_DMA
|
|
default X86_GOLDFISH
|
|
help
|
|
Say Y here to get to see options for the Goldfish virtual platform.
|
|
This option alone does not add any kernel code.
|
|
|
|
Unless you are building for the Android Goldfish emulator say N here.
|
|
|
|
if GOLDFISH
|
|
|
|
config GOLDFISH_PIPE
|
|
tristate "Goldfish virtual device for QEMU pipes"
|
|
help
|
|
This is a virtual device to drive the QEMU pipe interface used by
|
|
the Goldfish Android Virtual Device.
|
|
|
|
endif # GOLDFISH
|