6e0391e48c
A root node is required to apply DT overlays. A root node is usually present after commit7b937cc243("of: Create of_root if no dtb provided by firmware"), except for on arm64 systems booted with ACPI tables. In that case, the root node is intentionally not populated because it would "allow DT devices to be instantiated atop an ACPI base system"[1]. Introduce an OF function that skips the kunit test if the root node isn't populated. Limit the test to when both CONFIG_ARM64 and CONFIG_ACPI are set, because otherwise the lack of a root node is a bug. Make the function private and take a kunit test parameter so that it can't be abused to test for the presence of the root node in non-test code. Use this function to skip tests that require the root node. Currently that's the DT tests and any tests that apply overlays. Reported-by: Guenter Roeck <linux@roeck-us.net> Closes: https://lore.kernel.org/r/6cd337fb-38f0-41cb-b942-5844b84433db@roeck-us.net Link: https://lore.kernel.org/r/Zd4dQpHO7em1ji67@FVFF77S0Q05N.cambridge.arm.com [1] Fixes:893ecc6d2d("of: Add KUnit test to confirm DTB is loaded") Signed-off-by: Stephen Boyd <sboyd@kernel.org> Tested-by: Guenter Roeck <linux@roeck-us.net> Acked-by: Mark Rutland <mark.rutland@arm.com> Link: https://lore.kernel.org/r/20241009204133.1169931-1-sboyd@kernel.org Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
119 lines
3.1 KiB
C
119 lines
3.1 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* KUnit tests for device tree overlays
|
|
*/
|
|
#include <linux/device/bus.h>
|
|
#include <linux/kconfig.h>
|
|
#include <linux/of.h>
|
|
#include <linux/of_platform.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
#include <kunit/of.h>
|
|
#include <kunit/test.h>
|
|
|
|
#include "of_private.h"
|
|
|
|
static const char * const kunit_node_name = "kunit-test";
|
|
static const char * const kunit_compatible = "test,empty";
|
|
|
|
/* Test that of_overlay_apply_kunit() adds a node to the live tree */
|
|
static void of_overlay_apply_kunit_apply(struct kunit *test)
|
|
{
|
|
struct device_node *np;
|
|
|
|
KUNIT_ASSERT_EQ(test, 0,
|
|
of_overlay_apply_kunit(test, kunit_overlay_test));
|
|
|
|
np = of_find_node_by_name(NULL, kunit_node_name);
|
|
KUNIT_EXPECT_NOT_ERR_OR_NULL(test, np);
|
|
of_node_put(np);
|
|
}
|
|
|
|
/*
|
|
* Test that of_overlay_apply_kunit() creates platform devices with the
|
|
* expected device_node
|
|
*/
|
|
static void of_overlay_apply_kunit_platform_device(struct kunit *test)
|
|
{
|
|
struct platform_device *pdev;
|
|
struct device_node *np;
|
|
|
|
KUNIT_ASSERT_EQ(test, 0,
|
|
of_overlay_apply_kunit(test, kunit_overlay_test));
|
|
|
|
np = of_find_node_by_name(NULL, kunit_node_name);
|
|
of_node_put_kunit(test, np);
|
|
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, np);
|
|
|
|
pdev = of_find_device_by_node(np);
|
|
KUNIT_EXPECT_NOT_ERR_OR_NULL(test, pdev);
|
|
if (pdev)
|
|
put_device(&pdev->dev);
|
|
}
|
|
|
|
static int of_overlay_bus_match_compatible(struct device *dev, const void *data)
|
|
{
|
|
return of_device_is_compatible(dev->of_node, data);
|
|
}
|
|
|
|
/* Test that of_overlay_apply_kunit() cleans up after the test is finished */
|
|
static void of_overlay_apply_kunit_cleanup(struct kunit *test)
|
|
{
|
|
struct kunit fake;
|
|
struct platform_device *pdev;
|
|
struct device *dev;
|
|
struct device_node *np;
|
|
|
|
of_root_kunit_skip(test);
|
|
if (!IS_ENABLED(CONFIG_OF_EARLY_FLATTREE))
|
|
kunit_skip(test, "requires CONFIG_OF_EARLY_FLATTREE for root node");
|
|
|
|
kunit_init_test(&fake, "fake test", NULL);
|
|
KUNIT_ASSERT_EQ(test, fake.status, KUNIT_SUCCESS);
|
|
|
|
KUNIT_ASSERT_EQ(test, 0,
|
|
of_overlay_apply_kunit(&fake, kunit_overlay_test));
|
|
|
|
np = of_find_node_by_name(NULL, kunit_node_name);
|
|
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, np);
|
|
of_node_put_kunit(&fake, np);
|
|
|
|
pdev = of_find_device_by_node(np);
|
|
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, pdev);
|
|
put_device(&pdev->dev); /* Not derefing 'pdev' after this */
|
|
|
|
/* Remove overlay */
|
|
kunit_cleanup(&fake);
|
|
|
|
/* The node and device should be removed */
|
|
np = of_find_node_by_name(NULL, kunit_node_name);
|
|
KUNIT_EXPECT_PTR_EQ(test, NULL, np);
|
|
of_node_put(np);
|
|
|
|
dev = bus_find_device(&platform_bus_type, NULL, kunit_compatible,
|
|
of_overlay_bus_match_compatible);
|
|
KUNIT_EXPECT_PTR_EQ(test, NULL, dev);
|
|
put_device(dev);
|
|
}
|
|
|
|
static struct kunit_case of_overlay_apply_kunit_test_cases[] = {
|
|
KUNIT_CASE(of_overlay_apply_kunit_apply),
|
|
KUNIT_CASE(of_overlay_apply_kunit_platform_device),
|
|
KUNIT_CASE(of_overlay_apply_kunit_cleanup),
|
|
{}
|
|
};
|
|
|
|
/*
|
|
* Test suite for test managed device tree overlays.
|
|
*/
|
|
static struct kunit_suite of_overlay_apply_kunit_suite = {
|
|
.name = "of_overlay_apply_kunit",
|
|
.test_cases = of_overlay_apply_kunit_test_cases,
|
|
};
|
|
|
|
kunit_test_suites(
|
|
&of_overlay_apply_kunit_suite,
|
|
);
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_DESCRIPTION("KUnit tests for device tree overlays");
|