0ec893508e
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() is renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: David S. Miller <davem@davemloft.net>
98 lines
2.1 KiB
C
98 lines
2.1 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright (C) 2011, 2012 Cavium, Inc.
|
|
*/
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/gpio/consumer.h>
|
|
#include <linux/mdio-mux.h>
|
|
#include <linux/module.h>
|
|
#include <linux/of_mdio.h>
|
|
#include <linux/phy.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
#define DRV_VERSION "1.1"
|
|
#define DRV_DESCRIPTION "GPIO controlled MDIO bus multiplexer driver"
|
|
|
|
struct mdio_mux_gpio_state {
|
|
struct gpio_descs *gpios;
|
|
void *mux_handle;
|
|
};
|
|
|
|
static int mdio_mux_gpio_switch_fn(int current_child, int desired_child,
|
|
void *data)
|
|
{
|
|
struct mdio_mux_gpio_state *s = data;
|
|
DECLARE_BITMAP(values, BITS_PER_TYPE(desired_child));
|
|
|
|
if (current_child == desired_child)
|
|
return 0;
|
|
|
|
values[0] = desired_child;
|
|
|
|
gpiod_set_array_value_cansleep(s->gpios->ndescs, s->gpios->desc,
|
|
s->gpios->info, values);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int mdio_mux_gpio_probe(struct platform_device *pdev)
|
|
{
|
|
struct mdio_mux_gpio_state *s;
|
|
struct gpio_descs *gpios;
|
|
int r;
|
|
|
|
gpios = devm_gpiod_get_array(&pdev->dev, NULL, GPIOD_OUT_LOW);
|
|
if (IS_ERR(gpios))
|
|
return PTR_ERR(gpios);
|
|
|
|
s = devm_kzalloc(&pdev->dev, sizeof(*s), GFP_KERNEL);
|
|
if (!s)
|
|
return -ENOMEM;
|
|
|
|
s->gpios = gpios;
|
|
|
|
r = mdio_mux_init(&pdev->dev, pdev->dev.of_node,
|
|
mdio_mux_gpio_switch_fn, &s->mux_handle, s, NULL);
|
|
|
|
if (r != 0)
|
|
return r;
|
|
|
|
pdev->dev.platform_data = s;
|
|
return 0;
|
|
}
|
|
|
|
static void mdio_mux_gpio_remove(struct platform_device *pdev)
|
|
{
|
|
struct mdio_mux_gpio_state *s = dev_get_platdata(&pdev->dev);
|
|
mdio_mux_uninit(s->mux_handle);
|
|
}
|
|
|
|
static const struct of_device_id mdio_mux_gpio_match[] = {
|
|
{
|
|
.compatible = "mdio-mux-gpio",
|
|
},
|
|
{
|
|
/* Legacy compatible property. */
|
|
.compatible = "cavium,mdio-mux-sn74cbtlv3253",
|
|
},
|
|
{},
|
|
};
|
|
MODULE_DEVICE_TABLE(of, mdio_mux_gpio_match);
|
|
|
|
static struct platform_driver mdio_mux_gpio_driver = {
|
|
.driver = {
|
|
.name = "mdio-mux-gpio",
|
|
.of_match_table = mdio_mux_gpio_match,
|
|
},
|
|
.probe = mdio_mux_gpio_probe,
|
|
.remove_new = mdio_mux_gpio_remove,
|
|
};
|
|
|
|
module_platform_driver(mdio_mux_gpio_driver);
|
|
|
|
MODULE_DESCRIPTION(DRV_DESCRIPTION);
|
|
MODULE_VERSION(DRV_VERSION);
|
|
MODULE_AUTHOR("David Daney");
|
|
MODULE_LICENSE("GPL v2");
|