9bcf30348f
* Move the calculation of the AMD boost numerator outside of amd-pstate, correcting acpi-cpufreq on systems with preferred cores * Harden preferred core detection to avoid potential false positives * Add extra unit test coverage for mode state machine -----BEGIN PGP SIGNATURE----- iQJOBAABCgA4FiEECwtuSU6dXvs5GA2aLRkspiR3AnYFAmbhviEaHG1hcmlvLmxp bW9uY2llbGxvQGFtZC5jb20ACgkQLRkspiR3AnYqDA//TrvmXcpk1mnVJw3Y7MG0 /n8dsLpxqVtEf+USnlGR+iRhgSQ/W/Kr7b5a+jmdCwpHChuWHt2FnNgcHLIxDnZC vmEJ02/2BCRoPKvcvV4VTh0ATu3O9nqwQiBVWBdNjDy+Dzr0pzA+SQopt1hCIsO2 mzUodhpiBqYKlMf/i6+aM1gZCGGqoRC40aGqnJsgegb61vl7zIc2ZcbTxUQlyTfv t6J73IXLx8+YtrjejBYc7mRHhMQ2hCKy92C/8cNoGocj5faSKsAA3OUDcWq8qX0U zK3GGGdW8MLHSbt3VyntstnfiLL7TnzowcjvrMudIWpjC1987GlE9BApbN9VRZ8e ARN3Y7/ltjut/1fRB97BwjI9aDpzA0122Qzy4UOcK8o+be1eIr+ihV3Z9EN/snWg 0L/oq5+rGHvvIzf1BwGhoPSvgBIu7eMIYDcRxKPlEiKsbXrL4DdJC/nXgaZ/HiGO eHx1dNy7LFrdnEwVI1frZWC6ZuZcpmOBdhnfU+leVxzB3Z++Qc266rsxKBsc5taZ PPV18pxfbbl3iL85KDIbuBUCmA0aY8WEdCKtfXpl7zlB5g0fZQLyYeUbvahK08Sk vyQAnPECbX/4v1Vx54Z70GPk0XD2+TXdg8yApnXrmRc36z/SLdprk5hPKbKhZu/r iPxFUnvd0HCtjsLrsq/qUiQ= =R4HZ -----END PGP SIGNATURE----- Merge tag 'amd-pstate-v6.12-2024-09-11' of ssh://gitolite.kernel.org/pub/scm/linux/kernel/git/superm1/linux Merge the second round of amd-pstate changes for 6.12 from Mario Limonciello: "* Move the calculation of the AMD boost numerator outside of amd-pstate, correcting acpi-cpufreq on systems with preferred cores * Harden preferred core detection to avoid potential false positives * Add extra unit test coverage for mode state machine" * tag 'amd-pstate-v6.12-2024-09-11' of ssh://gitolite.kernel.org/pub/scm/linux/kernel/git/superm1/linux: cpufreq/amd-pstate-ut: Fix an "Uninitialized variables" issue cpufreq/amd-pstate-ut: Add test case for mode switches cpufreq/amd-pstate: Export symbols for changing modes amd-pstate: Add missing documentation for `amd_pstate_prefcore_ranking` cpufreq: amd-pstate: Add documentation for `amd_pstate_hw_prefcore` cpufreq: amd-pstate: Optimize amd_pstate_update_limits() cpufreq: amd-pstate: Merge amd_pstate_highest_perf_set() into amd_get_boost_ratio_numerator() x86/amd: Detect preferred cores in amd_get_boost_ratio_numerator() x86/amd: Move amd_get_highest_perf() out of amd-pstate ACPI: CPPC: Adjust debug messages in amd_set_max_freq_ratio() to warn ACPI: CPPC: Drop check for non zero perf ratio x86/amd: Rename amd_get_highest_perf() to amd_get_boost_ratio_numerator() ACPI: CPPC: Adjust return code for inline functions in !CONFIG_ACPI_CPPC_LIB x86/amd: Move amd_get_highest_perf() from amd.c to cppc.c
329 lines
9.6 KiB
C
329 lines
9.6 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* AMD Processor P-state Frequency Driver Unit Test
|
|
*
|
|
* Copyright (C) 2022 Advanced Micro Devices, Inc. All Rights Reserved.
|
|
*
|
|
* Author: Meng Li <li.meng@amd.com>
|
|
*
|
|
* The AMD P-State Unit Test is a test module for testing the amd-pstate
|
|
* driver. 1) It can help all users to verify their processor support
|
|
* (SBIOS/Firmware or Hardware). 2) Kernel can have a basic function
|
|
* test to avoid the kernel regression during the update. 3) We can
|
|
* introduce more functional or performance tests to align the result
|
|
* together, it will benefit power and performance scale optimization.
|
|
*
|
|
* This driver implements basic framework with plans to enhance it with
|
|
* additional test cases to improve the depth and coverage of the test.
|
|
*
|
|
* See Documentation/admin-guide/pm/amd-pstate.rst Unit Tests for
|
|
* amd-pstate to get more detail.
|
|
*/
|
|
|
|
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/moduleparam.h>
|
|
#include <linux/fs.h>
|
|
|
|
#include <acpi/cppc_acpi.h>
|
|
|
|
#include "amd-pstate.h"
|
|
|
|
/*
|
|
* Abbreviations:
|
|
* amd_pstate_ut: used as a shortform for AMD P-State unit test.
|
|
* It helps to keep variable names smaller, simpler
|
|
*/
|
|
enum amd_pstate_ut_result {
|
|
AMD_PSTATE_UT_RESULT_PASS,
|
|
AMD_PSTATE_UT_RESULT_FAIL,
|
|
};
|
|
|
|
struct amd_pstate_ut_struct {
|
|
const char *name;
|
|
void (*func)(u32 index);
|
|
enum amd_pstate_ut_result result;
|
|
};
|
|
|
|
/*
|
|
* Kernel module for testing the AMD P-State unit test
|
|
*/
|
|
static void amd_pstate_ut_acpi_cpc_valid(u32 index);
|
|
static void amd_pstate_ut_check_enabled(u32 index);
|
|
static void amd_pstate_ut_check_perf(u32 index);
|
|
static void amd_pstate_ut_check_freq(u32 index);
|
|
static void amd_pstate_ut_check_driver(u32 index);
|
|
|
|
static struct amd_pstate_ut_struct amd_pstate_ut_cases[] = {
|
|
{"amd_pstate_ut_acpi_cpc_valid", amd_pstate_ut_acpi_cpc_valid },
|
|
{"amd_pstate_ut_check_enabled", amd_pstate_ut_check_enabled },
|
|
{"amd_pstate_ut_check_perf", amd_pstate_ut_check_perf },
|
|
{"amd_pstate_ut_check_freq", amd_pstate_ut_check_freq },
|
|
{"amd_pstate_ut_check_driver", amd_pstate_ut_check_driver }
|
|
};
|
|
|
|
static bool get_shared_mem(void)
|
|
{
|
|
bool result = false;
|
|
|
|
if (!boot_cpu_has(X86_FEATURE_CPPC))
|
|
result = true;
|
|
|
|
return result;
|
|
}
|
|
|
|
/*
|
|
* check the _CPC object is present in SBIOS.
|
|
*/
|
|
static void amd_pstate_ut_acpi_cpc_valid(u32 index)
|
|
{
|
|
if (acpi_cpc_valid())
|
|
amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_PASS;
|
|
else {
|
|
amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_FAIL;
|
|
pr_err("%s the _CPC object is not present in SBIOS!\n", __func__);
|
|
}
|
|
}
|
|
|
|
static void amd_pstate_ut_pstate_enable(u32 index)
|
|
{
|
|
int ret = 0;
|
|
u64 cppc_enable = 0;
|
|
|
|
ret = rdmsrl_safe(MSR_AMD_CPPC_ENABLE, &cppc_enable);
|
|
if (ret) {
|
|
amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_FAIL;
|
|
pr_err("%s rdmsrl_safe MSR_AMD_CPPC_ENABLE ret=%d error!\n", __func__, ret);
|
|
return;
|
|
}
|
|
if (cppc_enable)
|
|
amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_PASS;
|
|
else {
|
|
amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_FAIL;
|
|
pr_err("%s amd pstate must be enabled!\n", __func__);
|
|
}
|
|
}
|
|
|
|
/*
|
|
* check if amd pstate is enabled
|
|
*/
|
|
static void amd_pstate_ut_check_enabled(u32 index)
|
|
{
|
|
if (get_shared_mem())
|
|
amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_PASS;
|
|
else
|
|
amd_pstate_ut_pstate_enable(index);
|
|
}
|
|
|
|
/*
|
|
* check if performance values are reasonable.
|
|
* highest_perf >= nominal_perf > lowest_nonlinear_perf > lowest_perf > 0
|
|
*/
|
|
static void amd_pstate_ut_check_perf(u32 index)
|
|
{
|
|
int cpu = 0, ret = 0;
|
|
u32 highest_perf = 0, nominal_perf = 0, lowest_nonlinear_perf = 0, lowest_perf = 0;
|
|
u64 cap1 = 0;
|
|
struct cppc_perf_caps cppc_perf;
|
|
struct cpufreq_policy *policy = NULL;
|
|
struct amd_cpudata *cpudata = NULL;
|
|
|
|
for_each_possible_cpu(cpu) {
|
|
policy = cpufreq_cpu_get(cpu);
|
|
if (!policy)
|
|
break;
|
|
cpudata = policy->driver_data;
|
|
|
|
if (get_shared_mem()) {
|
|
ret = cppc_get_perf_caps(cpu, &cppc_perf);
|
|
if (ret) {
|
|
amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_FAIL;
|
|
pr_err("%s cppc_get_perf_caps ret=%d error!\n", __func__, ret);
|
|
goto skip_test;
|
|
}
|
|
|
|
highest_perf = cppc_perf.highest_perf;
|
|
nominal_perf = cppc_perf.nominal_perf;
|
|
lowest_nonlinear_perf = cppc_perf.lowest_nonlinear_perf;
|
|
lowest_perf = cppc_perf.lowest_perf;
|
|
} else {
|
|
ret = rdmsrl_safe_on_cpu(cpu, MSR_AMD_CPPC_CAP1, &cap1);
|
|
if (ret) {
|
|
amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_FAIL;
|
|
pr_err("%s read CPPC_CAP1 ret=%d error!\n", __func__, ret);
|
|
goto skip_test;
|
|
}
|
|
|
|
highest_perf = AMD_CPPC_HIGHEST_PERF(cap1);
|
|
nominal_perf = AMD_CPPC_NOMINAL_PERF(cap1);
|
|
lowest_nonlinear_perf = AMD_CPPC_LOWNONLIN_PERF(cap1);
|
|
lowest_perf = AMD_CPPC_LOWEST_PERF(cap1);
|
|
}
|
|
|
|
if (highest_perf != READ_ONCE(cpudata->highest_perf) && !cpudata->hw_prefcore) {
|
|
pr_err("%s cpu%d highest=%d %d highest perf doesn't match\n",
|
|
__func__, cpu, highest_perf, cpudata->highest_perf);
|
|
goto skip_test;
|
|
}
|
|
if ((nominal_perf != READ_ONCE(cpudata->nominal_perf)) ||
|
|
(lowest_nonlinear_perf != READ_ONCE(cpudata->lowest_nonlinear_perf)) ||
|
|
(lowest_perf != READ_ONCE(cpudata->lowest_perf))) {
|
|
amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_FAIL;
|
|
pr_err("%s cpu%d nominal=%d %d lowest_nonlinear=%d %d lowest=%d %d, they should be equal!\n",
|
|
__func__, cpu, nominal_perf, cpudata->nominal_perf,
|
|
lowest_nonlinear_perf, cpudata->lowest_nonlinear_perf,
|
|
lowest_perf, cpudata->lowest_perf);
|
|
goto skip_test;
|
|
}
|
|
|
|
if (!((highest_perf >= nominal_perf) &&
|
|
(nominal_perf > lowest_nonlinear_perf) &&
|
|
(lowest_nonlinear_perf > lowest_perf) &&
|
|
(lowest_perf > 0))) {
|
|
amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_FAIL;
|
|
pr_err("%s cpu%d highest=%d >= nominal=%d > lowest_nonlinear=%d > lowest=%d > 0, the formula is incorrect!\n",
|
|
__func__, cpu, highest_perf, nominal_perf,
|
|
lowest_nonlinear_perf, lowest_perf);
|
|
goto skip_test;
|
|
}
|
|
cpufreq_cpu_put(policy);
|
|
}
|
|
|
|
amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_PASS;
|
|
return;
|
|
skip_test:
|
|
cpufreq_cpu_put(policy);
|
|
}
|
|
|
|
/*
|
|
* Check if frequency values are reasonable.
|
|
* max_freq >= nominal_freq > lowest_nonlinear_freq > min_freq > 0
|
|
* check max freq when set support boost mode.
|
|
*/
|
|
static void amd_pstate_ut_check_freq(u32 index)
|
|
{
|
|
int cpu = 0;
|
|
struct cpufreq_policy *policy = NULL;
|
|
struct amd_cpudata *cpudata = NULL;
|
|
u32 nominal_freq_khz;
|
|
|
|
for_each_possible_cpu(cpu) {
|
|
policy = cpufreq_cpu_get(cpu);
|
|
if (!policy)
|
|
break;
|
|
cpudata = policy->driver_data;
|
|
|
|
nominal_freq_khz = cpudata->nominal_freq*1000;
|
|
if (!((cpudata->max_freq >= nominal_freq_khz) &&
|
|
(nominal_freq_khz > cpudata->lowest_nonlinear_freq) &&
|
|
(cpudata->lowest_nonlinear_freq > cpudata->min_freq) &&
|
|
(cpudata->min_freq > 0))) {
|
|
amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_FAIL;
|
|
pr_err("%s cpu%d max=%d >= nominal=%d > lowest_nonlinear=%d > min=%d > 0, the formula is incorrect!\n",
|
|
__func__, cpu, cpudata->max_freq, nominal_freq_khz,
|
|
cpudata->lowest_nonlinear_freq, cpudata->min_freq);
|
|
goto skip_test;
|
|
}
|
|
|
|
if (cpudata->min_freq != policy->min) {
|
|
amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_FAIL;
|
|
pr_err("%s cpu%d cpudata_min_freq=%d policy_min=%d, they should be equal!\n",
|
|
__func__, cpu, cpudata->min_freq, policy->min);
|
|
goto skip_test;
|
|
}
|
|
|
|
if (cpudata->boost_supported) {
|
|
if ((policy->max == cpudata->max_freq) ||
|
|
(policy->max == nominal_freq_khz))
|
|
amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_PASS;
|
|
else {
|
|
amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_FAIL;
|
|
pr_err("%s cpu%d policy_max=%d should be equal cpu_max=%d or cpu_nominal=%d !\n",
|
|
__func__, cpu, policy->max, cpudata->max_freq,
|
|
nominal_freq_khz);
|
|
goto skip_test;
|
|
}
|
|
} else {
|
|
amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_FAIL;
|
|
pr_err("%s cpu%d must support boost!\n", __func__, cpu);
|
|
goto skip_test;
|
|
}
|
|
cpufreq_cpu_put(policy);
|
|
}
|
|
|
|
amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_PASS;
|
|
return;
|
|
skip_test:
|
|
cpufreq_cpu_put(policy);
|
|
}
|
|
|
|
static int amd_pstate_set_mode(enum amd_pstate_mode mode)
|
|
{
|
|
const char *mode_str = amd_pstate_get_mode_string(mode);
|
|
|
|
pr_debug("->setting mode to %s\n", mode_str);
|
|
|
|
return amd_pstate_update_status(mode_str, strlen(mode_str));
|
|
}
|
|
|
|
static void amd_pstate_ut_check_driver(u32 index)
|
|
{
|
|
enum amd_pstate_mode mode1, mode2 = AMD_PSTATE_DISABLE;
|
|
int ret;
|
|
|
|
for (mode1 = AMD_PSTATE_DISABLE; mode1 < AMD_PSTATE_MAX; mode1++) {
|
|
ret = amd_pstate_set_mode(mode1);
|
|
if (ret)
|
|
goto out;
|
|
for (mode2 = AMD_PSTATE_DISABLE; mode2 < AMD_PSTATE_MAX; mode2++) {
|
|
if (mode1 == mode2)
|
|
continue;
|
|
ret = amd_pstate_set_mode(mode2);
|
|
if (ret)
|
|
goto out;
|
|
}
|
|
}
|
|
out:
|
|
if (ret)
|
|
pr_warn("%s: failed to update status for %s->%s: %d\n", __func__,
|
|
amd_pstate_get_mode_string(mode1),
|
|
amd_pstate_get_mode_string(mode2), ret);
|
|
|
|
amd_pstate_ut_cases[index].result = ret ?
|
|
AMD_PSTATE_UT_RESULT_FAIL :
|
|
AMD_PSTATE_UT_RESULT_PASS;
|
|
}
|
|
|
|
static int __init amd_pstate_ut_init(void)
|
|
{
|
|
u32 i = 0, arr_size = ARRAY_SIZE(amd_pstate_ut_cases);
|
|
|
|
for (i = 0; i < arr_size; i++) {
|
|
amd_pstate_ut_cases[i].func(i);
|
|
switch (amd_pstate_ut_cases[i].result) {
|
|
case AMD_PSTATE_UT_RESULT_PASS:
|
|
pr_info("%-4d %-20s\t success!\n", i+1, amd_pstate_ut_cases[i].name);
|
|
break;
|
|
case AMD_PSTATE_UT_RESULT_FAIL:
|
|
default:
|
|
pr_info("%-4d %-20s\t fail!\n", i+1, amd_pstate_ut_cases[i].name);
|
|
break;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void __exit amd_pstate_ut_exit(void)
|
|
{
|
|
}
|
|
|
|
module_init(amd_pstate_ut_init);
|
|
module_exit(amd_pstate_ut_exit);
|
|
|
|
MODULE_AUTHOR("Meng Li <li.meng@amd.com>");
|
|
MODULE_DESCRIPTION("AMD P-state driver Test module");
|
|
MODULE_LICENSE("GPL");
|