fe0b1e9a73
There are four state machines in drbd that use a common infrastructure, with
a cast to an incompatible function type in REMEMBER_STATE_CHANGE that clang-16
now warns about:
drivers/block/drbd/drbd_state.c:1632:3: error: cast from 'int (*)(struct sk_buff *, unsigned int, struct drbd_resource_state_change *, enum drbd_notification_type)' to 'typeof (last_func)' (aka 'int (*)(struct sk_buff *, unsigned int, void *, enum drbd_notification_type)') converts to incompatible function type [-Werror,-Wcast-function-type-strict]
1632 | REMEMBER_STATE_CHANGE(notify_resource_state_change,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1633 | resource_state_change, NOTIFY_CHANGE);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/block/drbd/drbd_state.c:1619:17: note: expanded from macro 'REMEMBER_STATE_CHANGE'
1619 | last_func = (typeof(last_func))func; \
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/block/drbd/drbd_state.c:1641:4: error: cast from 'int (*)(struct sk_buff *, unsigned int, struct drbd_connection_state_change *, enum drbd_notification_type)' to 'typeof (last_func)' (aka 'int (*)(struct sk_buff *, unsigned int, void *, enum drbd_notification_type)') converts to incompatible function type [-Werror,-Wcast-function-type-strict]
1641 | REMEMBER_STATE_CHANGE(notify_connection_state_change,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1642 | connection_state_change, NOTIFY_CHANGE);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Change these all to actually expect a void pointer to be passed, which
matches the caller.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20240213100354.457128-1-arnd@kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
65 lines
1.9 KiB
C
65 lines
1.9 KiB
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
#ifndef DRBD_STATE_CHANGE_H
|
|
#define DRBD_STATE_CHANGE_H
|
|
|
|
struct drbd_resource_state_change {
|
|
struct drbd_resource *resource;
|
|
enum drbd_role role[2];
|
|
bool susp[2];
|
|
bool susp_nod[2];
|
|
bool susp_fen[2];
|
|
};
|
|
|
|
struct drbd_device_state_change {
|
|
struct drbd_device *device;
|
|
enum drbd_disk_state disk_state[2];
|
|
};
|
|
|
|
struct drbd_connection_state_change {
|
|
struct drbd_connection *connection;
|
|
enum drbd_conns cstate[2]; /* drbd9: enum drbd_conn_state */
|
|
enum drbd_role peer_role[2];
|
|
};
|
|
|
|
struct drbd_peer_device_state_change {
|
|
struct drbd_peer_device *peer_device;
|
|
enum drbd_disk_state disk_state[2];
|
|
enum drbd_conns repl_state[2]; /* drbd9: enum drbd_repl_state */
|
|
bool resync_susp_user[2];
|
|
bool resync_susp_peer[2];
|
|
bool resync_susp_dependency[2];
|
|
};
|
|
|
|
struct drbd_state_change {
|
|
struct list_head list;
|
|
unsigned int n_devices;
|
|
unsigned int n_connections;
|
|
struct drbd_resource_state_change resource[1];
|
|
struct drbd_device_state_change *devices;
|
|
struct drbd_connection_state_change *connections;
|
|
struct drbd_peer_device_state_change *peer_devices;
|
|
};
|
|
|
|
extern struct drbd_state_change *remember_old_state(struct drbd_resource *, gfp_t);
|
|
extern void copy_old_to_new_state_change(struct drbd_state_change *);
|
|
extern void forget_state_change(struct drbd_state_change *);
|
|
|
|
extern int notify_resource_state_change(struct sk_buff *,
|
|
unsigned int,
|
|
void *,
|
|
enum drbd_notification_type type);
|
|
extern int notify_connection_state_change(struct sk_buff *,
|
|
unsigned int,
|
|
void *,
|
|
enum drbd_notification_type type);
|
|
extern int notify_device_state_change(struct sk_buff *,
|
|
unsigned int,
|
|
void *,
|
|
enum drbd_notification_type type);
|
|
extern int notify_peer_device_state_change(struct sk_buff *,
|
|
unsigned int,
|
|
void *,
|
|
enum drbd_notification_type type);
|
|
|
|
#endif /* DRBD_STATE_CHANGE_H */
|