199da8714c
Nathan reported below building error: ===== $ curl -LSso .config https://git.alpinelinux.org/aports/plain/community/linux-edge/config-edge.armv7 $ make -skj"$(nproc)" ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- olddefconfig all .. arm-linux-gnueabi-ld: arch/arm/kernel/machine_kexec.o: in function `arch_crash_save_vmcoreinfo': machine_kexec.c:(.text+0x488): undefined reference to `vmcoreinfo_append_str' ==== On architecutres, like arm, s390, ppc, sh, function arch_crash_save_vmcoreinfo() is located in machine_kexec.c and it can only be compiled in when CONFIG_KEXEC_CORE=y. That's not right because arch_crash_save_vmcoreinfo() is used to export arch specific vmcoreinfo. CONFIG_VMCORE_INFO is supposed to control its compiling in. However, CONFIG_VMVCORE_INFO could be independent of CONFIG_KEXEC_CORE, e.g CONFIG_PROC_KCORE=y will select CONFIG_VMVCORE_INFO. Or CONFIG_KEXEC/CONFIG_KEXEC_FILE is set while CONFIG_CRASH_DUMP is not set, it will report linking error. So, on arm, s390, ppc and sh, move arch_crash_save_vmcoreinfo out to a new file vmcore_info.c. Let CONFIG_VMCORE_INFO decide if compiling in arch_crash_save_vmcoreinfo(). [akpm@linux-foundation.org: remove stray newlines at eof] Link: https://lkml.kernel.org/r/20240129135033.157195-3-bhe@redhat.com Signed-off-by: Baoquan He <bhe@redhat.com> Reported-by: Nathan Chancellor <nathan@kernel.org> Closes: https://lore.kernel.org/all/20240126045551.GA126645@dev-arch.thelio-3990X/T/#u Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Eric W. Biederman <ebiederm@xmission.com> Cc: Hari Bathini <hbathini@linux.ibm.com> Cc: Klara Modin <klarasmodin@gmail.com> Cc: Michael Kelley <mhklinux@outlook.com> Cc: Pingfan Liu <piliu@redhat.com> Cc: Stephen Rothwell <sfr@canb.auug.org.au> Cc: Yang Li <yang.lee@linux.alibaba.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
51 lines
1.5 KiB
Makefile
51 lines
1.5 KiB
Makefile
# SPDX-License-Identifier: GPL-2.0
|
|
#
|
|
# Makefile for the Linux/SuperH kernel.
|
|
#
|
|
|
|
extra-y := vmlinux.lds
|
|
|
|
ifdef CONFIG_FUNCTION_TRACER
|
|
# Do not profile debug and lowlevel utilities
|
|
CFLAGS_REMOVE_ftrace.o = -pg
|
|
endif
|
|
|
|
CFLAGS_REMOVE_return_address.o = -pg
|
|
|
|
obj-y := head_32.o debugtraps.o dumpstack.o \
|
|
idle.o io.o irq.o irq_32.o kdebugfs.o \
|
|
machvec.o nmi_debug.o process.o \
|
|
process_32.o ptrace.o ptrace_32.o \
|
|
reboot.o return_address.o \
|
|
setup.o signal_32.o sys_sh.o \
|
|
syscalls_32.o time.o topology.o traps.o \
|
|
traps_32.o unwinder.o
|
|
|
|
ifndef CONFIG_GENERIC_IOMAP
|
|
obj-y += iomap.o
|
|
obj-$(CONFIG_HAS_IOPORT_MAP) += ioport.o
|
|
endif
|
|
|
|
obj-y += sys_sh32.o
|
|
obj-y += cpu/
|
|
obj-$(CONFIG_VSYSCALL) += vsyscall/
|
|
obj-$(CONFIG_SMP) += smp.o
|
|
obj-$(CONFIG_SH_STANDARD_BIOS) += sh_bios.o
|
|
obj-$(CONFIG_KGDB) += kgdb.o
|
|
obj-$(CONFIG_MODULES) += sh_ksyms_32.o module.o
|
|
obj-$(CONFIG_KEXEC_CORE) += machine_kexec.o relocate_kernel.o
|
|
obj-$(CONFIG_VMCORE_INFO) += vmcore_info.o
|
|
obj-$(CONFIG_CRASH_DUMP) += crash_dump.o
|
|
obj-$(CONFIG_STACKTRACE) += stacktrace.o
|
|
obj-$(CONFIG_IO_TRAPPED) += io_trapped.o
|
|
obj-$(CONFIG_KPROBES) += kprobes.o
|
|
obj-$(CONFIG_DYNAMIC_FTRACE) += ftrace.o
|
|
obj-$(CONFIG_FTRACE_SYSCALLS) += ftrace.o
|
|
obj-$(CONFIG_FUNCTION_GRAPH_TRACER) += ftrace.o
|
|
obj-$(CONFIG_DUMP_CODE) += disassemble.o
|
|
obj-$(CONFIG_HIBERNATION) += swsusp.o
|
|
obj-$(CONFIG_DWARF_UNWINDER) += dwarf.o
|
|
obj-$(CONFIG_PERF_EVENTS) += perf_event.o perf_callchain.o
|
|
obj-$(CONFIG_DMA_NONCOHERENT) += dma-coherent.o
|
|
obj-$(CONFIG_HAVE_HW_BREAKPOINT) += hw_breakpoint.o
|