a9ff696160
Making virt_to_pfn() a static inline taking a strongly typed (const void *) makes the contract of a passing a pointer of that type to the function explicit and exposes any misuse of the macro virt_to_pfn() acting polymorphic and accepting many types such as (void *), (unitptr_t) or (unsigned long) as arguments without warnings. Doing this is a bit intrusive: virt_to_pfn() requires PHYS_PFN_OFFSET and PAGE_SHIFT to be defined, and this is defined in <asm/page.h>, so this must be included *before* <asm/memory.h>. The use of macros were obscuring the unclear inclusion order here, as the macros would eventually be resolved, but a static inline like this cannot be compiled with unresolved macros. The naive solution to include <asm/page.h> at the top of <asm/memory.h> does not work, because <asm/memory.h> sometimes includes <asm/page.h> at the end of itself, which would create a confusing inclusion loop. So instead, take the approach to always unconditionally include <asm/page.h> at the end of <asm/memory.h> arch/arm uses <asm/memory.h> explicitly in a lot of places, however it turns out that if we just unconditionally include <asm/memory.h> into <asm/page.h> and switch all inclusions of <asm/memory.h> to <asm/page.h> instead, we enforce the right order and <asm/memory.h> will always have access to the definitions. Put an inclusion guard in place making it impossible to include <asm/memory.h> explicitly. Link: https://lore.kernel.org/linux-mm/20220701160004.2ffff4e5ab59a55499f4c736@linux-foundation.org/ Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
128 lines
2.8 KiB
C
128 lines
2.8 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright (C) 2014 Marvell Technology Group Ltd.
|
|
*
|
|
* Antoine Ténart <antoine.tenart@free-electrons.com>
|
|
*/
|
|
|
|
#include <linux/io.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/of.h>
|
|
#include <linux/of_address.h>
|
|
|
|
#include <asm/cacheflush.h>
|
|
#include <asm/cp15.h>
|
|
#include <asm/page.h>
|
|
#include <asm/smp_plat.h>
|
|
#include <asm/smp_scu.h>
|
|
|
|
/*
|
|
* There are two reset registers, one with self-clearing (SC)
|
|
* reset and one with non-self-clearing reset (NON_SC).
|
|
*/
|
|
#define CPU_RESET_SC 0x00
|
|
#define CPU_RESET_NON_SC 0x20
|
|
|
|
#define RESET_VECT 0x00
|
|
#define SW_RESET_ADDR 0x94
|
|
|
|
extern u32 boot_inst;
|
|
|
|
static void __iomem *cpu_ctrl;
|
|
|
|
static inline void berlin_perform_reset_cpu(unsigned int cpu)
|
|
{
|
|
u32 val;
|
|
|
|
val = readl(cpu_ctrl + CPU_RESET_NON_SC);
|
|
val &= ~BIT(cpu_logical_map(cpu));
|
|
writel(val, cpu_ctrl + CPU_RESET_NON_SC);
|
|
val |= BIT(cpu_logical_map(cpu));
|
|
writel(val, cpu_ctrl + CPU_RESET_NON_SC);
|
|
}
|
|
|
|
static int berlin_boot_secondary(unsigned int cpu, struct task_struct *idle)
|
|
{
|
|
if (!cpu_ctrl)
|
|
return -EFAULT;
|
|
|
|
/*
|
|
* Reset the CPU, making it to execute the instruction in the reset
|
|
* exception vector.
|
|
*/
|
|
berlin_perform_reset_cpu(cpu);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void __init berlin_smp_prepare_cpus(unsigned int max_cpus)
|
|
{
|
|
struct device_node *np;
|
|
void __iomem *scu_base;
|
|
void __iomem *vectors_base;
|
|
|
|
np = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-scu");
|
|
scu_base = of_iomap(np, 0);
|
|
of_node_put(np);
|
|
if (!scu_base)
|
|
return;
|
|
|
|
np = of_find_compatible_node(NULL, NULL, "marvell,berlin-cpu-ctrl");
|
|
cpu_ctrl = of_iomap(np, 0);
|
|
of_node_put(np);
|
|
if (!cpu_ctrl)
|
|
goto unmap_scu;
|
|
|
|
vectors_base = ioremap(VECTORS_BASE, SZ_32K);
|
|
if (!vectors_base)
|
|
goto unmap_scu;
|
|
|
|
scu_enable(scu_base);
|
|
|
|
/*
|
|
* Write the first instruction the CPU will execute after being reset
|
|
* in the reset exception vector.
|
|
*/
|
|
writel(boot_inst, vectors_base + RESET_VECT);
|
|
|
|
/*
|
|
* Write the secondary startup address into the SW reset address
|
|
* vector. This is used by boot_inst.
|
|
*/
|
|
writel(__pa_symbol(secondary_startup), vectors_base + SW_RESET_ADDR);
|
|
|
|
iounmap(vectors_base);
|
|
unmap_scu:
|
|
iounmap(scu_base);
|
|
}
|
|
|
|
#ifdef CONFIG_HOTPLUG_CPU
|
|
static void berlin_cpu_die(unsigned int cpu)
|
|
{
|
|
v7_exit_coherency_flush(louis);
|
|
while (1)
|
|
cpu_do_idle();
|
|
}
|
|
|
|
static int berlin_cpu_kill(unsigned int cpu)
|
|
{
|
|
u32 val;
|
|
|
|
val = readl(cpu_ctrl + CPU_RESET_NON_SC);
|
|
val &= ~BIT(cpu_logical_map(cpu));
|
|
writel(val, cpu_ctrl + CPU_RESET_NON_SC);
|
|
|
|
return 1;
|
|
}
|
|
#endif
|
|
|
|
static const struct smp_operations berlin_smp_ops __initconst = {
|
|
.smp_prepare_cpus = berlin_smp_prepare_cpus,
|
|
.smp_boot_secondary = berlin_boot_secondary,
|
|
#ifdef CONFIG_HOTPLUG_CPU
|
|
.cpu_die = berlin_cpu_die,
|
|
.cpu_kill = berlin_cpu_kill,
|
|
#endif
|
|
};
|
|
CPU_METHOD_OF_DECLARE(berlin_smp, "marvell,berlin-smp", &berlin_smp_ops);
|