kevin/linux
1
Fork 0
Code

static_call: Replace pointless WARN_ON() in static_call_module_notify()

Browse Source 
static_call_module_notify() triggers a WARN_ON(), when memory allocation
fails in __static_call_add_module().

That's not really justified, because the failure case must be correctly
handled by the well known call chain and the error code is passed
through to the initiating userspace application.

A memory allocation fail is not a fatal problem, but the WARN_ON() takes
the machine out when panic_on_warn is set.

Replace it with a pr_warn().

Fixes: 9183c3f9ed ("static_call: Add inline static call infrastructure")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/8734mf7pmb.ffs@tglx
This commit is contained in:
Thomas Gleixner 2024-09-04 11:08:28 +02:00 committed by Peter Zijlstra
parent 4b30051c48
commit fe513c2ef0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
kernel/static_call_inline.c
View File

@ -453,7 +453,7 @@ static int static_call_module_notify(struct notifier_block *nb,
case MODULE_STATE_COMING: case MODULE_STATE_COMING:
ret = static_call_add_module(mod); ret = static_call_add_module(mod);
if (ret) { if (ret) {
WARN(1, "Failed to allocate memory for static calls"); pr_warn("Failed to allocate memory for static calls\n");
static_call_del_module(mod); static_call_del_module(mod);
} }
break; break;