kevin/linux
1
Fork 0
Code

macintosh/therm_windtunnel: fix module unload.

Browse Source 
The of_device_unregister call in therm_windtunnel's module_exit procedure
does not fully reverse the effects of of_platform_device_create in the
module_init prodedure.  Once you unload this module, it is impossible
to load it ever again since only the first of_platform_device_create
call on the fan node succeeds.

This driver predates first git commit, and it turns out back then
of_platform_device_create worked differently than it does today.
So this is actually an old regression.

The appropriate function to undo of_platform_device_create now appears
to be of_platform_device_destroy, and switching to use this makes it
possible to unload and load the module as expected.

Signed-off-by: Nick Bowler <nbowler@draconx.ca>
Fixes: c6e126de43 ("of: Keep track of populated platform devices")
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20240711035428.16696-1-nbowler@draconx.ca
This commit is contained in:
Nick Bowler 2024-07-10 23:54:17 -04:00 committed by Michael Ellerman
parent db25a9625d
commit fd748e1771
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/macintosh/therm_windtunnel.c
View File

@ -549,7 +549,7 @@ g4fan_exit( void )
platform_driver_unregister( &therm_of_driver ); platform_driver_unregister( &therm_of_driver );
if( x.of_dev ) if( x.of_dev )
of_device_unregister( x.of_dev ); of_platform_device_destroy(&x.of_dev->dev, NULL);
} }
module_init(g4fan_init); module_init(g4fan_init);