kevin/linux
1
Fork 0
Code

thermal/drivers/generic-adc: Simplify probe() with local dev variable

Browse Source 
Simplify the probe() function by using local 'dev' instead of
&pdev->dev.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240709-thermal-probe-v1-11-241644e2b6e0@linaro.org
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
This commit is contained in:
Krzysztof Kozlowski 2024-07-09 14:59:41 +02:00 committed by Daniel Lezcano
parent bc55630c65
commit f637bfe26c
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
drivers/thermal/thermal-generic-adc.c
View File

@ -117,44 +117,45 @@ static int gadc_thermal_read_linear_lookup_table(struct device *dev,
static int gadc_thermal_probe(struct platform_device *pdev) static int gadc_thermal_probe(struct platform_device *pdev)
{ {
struct device *dev = &pdev->dev;
struct gadc_thermal_info *gti; struct gadc_thermal_info *gti;
int ret; int ret;
if (!pdev->dev.of_node) { if (!dev->of_node) {
dev_err(&pdev->dev, "Only DT based supported\n"); dev_err(dev, "Only DT based supported\n");
return -ENODEV; return -ENODEV;
} }
gti = devm_kzalloc(&pdev->dev, sizeof(*gti), GFP_KERNEL); gti = devm_kzalloc(dev, sizeof(*gti), GFP_KERNEL);
if (!gti) if (!gti)
return -ENOMEM; return -ENOMEM;
gti->channel = devm_iio_channel_get(&pdev->dev, "sensor-channel"); gti->channel = devm_iio_channel_get(dev, "sensor-channel");
if (IS_ERR(gti->channel)) { if (IS_ERR(gti->channel)) {
ret = PTR_ERR(gti->channel); ret = PTR_ERR(gti->channel);
if (ret != -EPROBE_DEFER) if (ret != -EPROBE_DEFER)
dev_err(&pdev->dev, "IIO channel not found: %d\n", ret); dev_err(dev, "IIO channel not found: %d\n", ret);
return ret; return ret;
} }
ret = gadc_thermal_read_linear_lookup_table(&pdev->dev, gti); ret = gadc_thermal_read_linear_lookup_table(dev, gti);
if (ret < 0) if (ret < 0)
return ret; return ret;
gti->dev = &pdev->dev; gti->dev = dev;
gti->tz_dev = devm_thermal_of_zone_register(&pdev->dev, 0, gti, gti->tz_dev = devm_thermal_of_zone_register(dev, 0, gti,
&gadc_thermal_ops); &gadc_thermal_ops);
if (IS_ERR(gti->tz_dev)) { if (IS_ERR(gti->tz_dev)) {
ret = PTR_ERR(gti->tz_dev); ret = PTR_ERR(gti->tz_dev);
if (ret != -EPROBE_DEFER) if (ret != -EPROBE_DEFER)
dev_err(&pdev->dev, dev_err(dev,
"Thermal zone sensor register failed: %d\n", "Thermal zone sensor register failed: %d\n",
ret); ret);
return ret; return ret;
} }
devm_thermal_add_hwmon_sysfs(&pdev->dev, gti->tz_dev); devm_thermal_add_hwmon_sysfs(dev, gti->tz_dev);
return 0; return 0;
} }