kevin/linux
1
Fork 0
Code

iio: accel: bma400: simplify with cleanup.h

Browse Source 
Allocate the memory with scoped/cleanup.h to reduce error handling and
make the code a bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://patch.msgid.link/20240705-cleanup-h-iio-v1-1-77114c7e84c5@linaro.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Krzysztof Kozlowski 2024-07-05 12:40:44 +02:00 committed by Jonathan Cameron
parent 244315b317
commit f44c314faa
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/iio/accel/bma400_core.c
View File

@ -13,6 +13,7 @@
#include <linux/bitfield.h> #include <linux/bitfield.h>
#include <linux/bitops.h> #include <linux/bitops.h>
#include <linux/cleanup.h>
#include <linux/device.h> #include <linux/device.h>
#include <linux/kernel.h> #include <linux/kernel.h>
#include <linux/module.h> #include <linux/module.h>
@ -795,21 +796,19 @@ static int bma400_enable_steps(struct bma400_data *data, int val)
static int bma400_get_steps_reg(struct bma400_data *data, int *val) static int bma400_get_steps_reg(struct bma400_data *data, int *val)
{ {
u8 *steps_raw;
int ret; int ret;
steps_raw = kmalloc(BMA400_STEP_RAW_LEN, GFP_KERNEL); u8 *steps_raw __free(kfree) = kmalloc(BMA400_STEP_RAW_LEN, GFP_KERNEL);
if (!steps_raw) if (!steps_raw)
return -ENOMEM; return -ENOMEM;
ret = regmap_bulk_read(data->regmap, BMA400_STEP_CNT0_REG, ret = regmap_bulk_read(data->regmap, BMA400_STEP_CNT0_REG,
steps_raw, BMA400_STEP_RAW_LEN); steps_raw, BMA400_STEP_RAW_LEN);
if (ret) { if (ret)
kfree(steps_raw);
return ret; return ret;
}
*val = get_unaligned_le24(steps_raw); *val = get_unaligned_le24(steps_raw);
kfree(steps_raw);
return IIO_VAL_INT; return IIO_VAL_INT;
} }