kevin/linux
1
Fork 0
Code

usb: host: Do not check for 0 return after calling platform_get_irq()

Browse Source 
It is not possible for platform_get_irq() to return 0. Use the
return value from platform_get_irq().

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: Justin Chen <justin.chen@broadcom.com>
Link: https://lore.kernel.org/r/20230802031236.2272196-1-ruanjinjie@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Ruan Jinjie 2023-08-02 11:12:36 +08:00 committed by Greg Kroah-Hartman
parent 98d6db05ed
commit f2e5812fb4
4 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/usb/host/ehci-atmel.c
View File

@ -102,8 +102,8 @@ static int ehci_atmel_drv_probe(struct platform_device *pdev)
pr_debug("Initializing Atmel-SoC USB Host Controller\n");
irq = platform_get_irq(pdev, 0);
if (irq <= 0) {
retval = -ENODEV;
if (irq < 0) {
retval = irq;
goto fail_create_hcd;
}

4
drivers/usb/host/ehci-brcm.c
View File

@ -140,8 +140,8 @@ static int ehci_brcm_probe(struct platform_device *pdev)
return err;
irq = platform_get_irq(pdev, 0);
if (irq <= 0)
return irq ? irq : -EINVAL;
if (irq < 0)
return irq;
/* Hook the hub control routine to work around a bug */
ehci_brcm_hc_driver.hub_control = ehci_brcm_hub_control;

4
drivers/usb/host/ehci-orion.c
View File

@ -218,8 +218,8 @@ static int ehci_orion_drv_probe(struct platform_device *pdev)
pr_debug("Initializing Orion-SoC USB Host Controller\n");
irq = platform_get_irq(pdev, 0);
if (irq <= 0) {
err = -ENODEV;
if (irq < 0) {
err = irq;
goto err;
}

4
drivers/usb/host/ehci-sh.c
View File

@ -82,8 +82,8 @@ static int ehci_hcd_sh_probe(struct platform_device *pdev)
return -ENODEV;
irq = platform_get_irq(pdev, 0);
if (irq <= 0) {
ret = -ENODEV;
if (irq < 0) {
ret = irq;
goto fail_create_hcd;
}