1

quota: remove unnecessary error code translation in dquot_quota_enable

Simply set error code to -EEXIST when quota limit is already enabled in
dquot_quota_enable to remove unnecessary error code translation.

Link: https://patch.msgid.link/20240715130534.2112678-5-shikemeng@huaweicloud.com
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Signed-off-by: Jan Kara <jack@suse.cz>
This commit is contained in:
Kemeng Shi 2024-07-15 21:05:34 +08:00 committed by Jan Kara
parent f439111b48
commit edb46ddbc5

View File

@ -2594,7 +2594,8 @@ static int dquot_quota_enable(struct super_block *sb, unsigned int flags)
goto out_err; goto out_err;
} }
if (sb_has_quota_limits_enabled(sb, type)) { if (sb_has_quota_limits_enabled(sb, type)) {
ret = -EBUSY; /* compatible with XFS */
ret = -EEXIST;
goto out_err; goto out_err;
} }
spin_lock(&dq_state_lock); spin_lock(&dq_state_lock);
@ -2608,9 +2609,6 @@ out_err:
if (flags & qtype_enforce_flag(type)) if (flags & qtype_enforce_flag(type))
dquot_disable(sb, type, DQUOT_LIMITS_ENABLED); dquot_disable(sb, type, DQUOT_LIMITS_ENABLED);
} }
/* Error code translation for better compatibility with XFS */
if (ret == -EBUSY)
ret = -EEXIST;
return ret; return ret;
} }