kevin/linux
1
Fork 0
Code

seccomp: Constify sysctl subhelpers

Browse Source 
The read_actions_logged() and write_actions_logged() helpers called by the
sysctl proc handler seccomp_actions_logged_handler() are already expecting
their sysctl table argument to be read-only. Actually mark the argument
as const in preparation[1] for global constification of the sysctl tables.

Suggested-by: Thomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/lkml/20240423-sysctl-const-handler-v3-11-e0beccb836e2@weissschuh.net/ [1]
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Reviewed-by: Thomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/r/20240508171337.work.861-kees@kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
This commit is contained in:
Kees Cook 2024-05-08 10:13:41 -07:00
parent 39cd87c4eb
commit e406737b11
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
kernel/seccomp.c
View File

@ -2334,7 +2334,7 @@ static bool seccomp_actions_logged_from_names(u32 *actions_logged, char *names)
return true; return true;
} }
static int read_actions_logged(struct ctl_table *ro_table, void *buffer, static int read_actions_logged(const struct ctl_table *ro_table, void *buffer,
size_t *lenp, loff_t *ppos) size_t *lenp, loff_t *ppos)
{ {
char names[sizeof(seccomp_actions_avail)]; char names[sizeof(seccomp_actions_avail)];
@ -2352,7 +2352,7 @@ static int read_actions_logged(struct ctl_table *ro_table, void *buffer,
return proc_dostring(&table, 0, buffer, lenp, ppos); return proc_dostring(&table, 0, buffer, lenp, ppos);
} }
static int write_actions_logged(struct ctl_table *ro_table, void *buffer, static int write_actions_logged(const struct ctl_table *ro_table, void *buffer,
size_t *lenp, loff_t *ppos, u32 *actions_logged) size_t *lenp, loff_t *ppos, u32 *actions_logged)
{ {
char names[sizeof(seccomp_actions_avail)]; char names[sizeof(seccomp_actions_avail)];