kevin/linux
1
Fork 0
Code

iio: adc: mp2629_adc: make use of regmap_clear_bits(), regmap_set_bits()

Browse Source 
Instead of using regmap_update_bits() and passing the mask twice, use
regmap_set_bits().

Instead of using regmap_update_bits() and passing val = 0, use
regmap_clear_bits().

Suggested-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://patch.msgid.link/20240617-review-v3-14-88d1338c4cca@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Trevor Gamblin 2024-06-17 09:49:54 -04:00 committed by Jonathan Cameron
parent 72df0511c1
commit e3007f6d59
1 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/iio/adc/mp2629_adc.c
View File

@ -131,8 +131,7 @@ static int mp2629_adc_probe(struct platform_device *pdev)
info->dev = dev; info->dev = dev;
platform_set_drvdata(pdev, indio_dev); platform_set_drvdata(pdev, indio_dev);
ret = regmap_update_bits(info->regmap, MP2629_REG_ADC_CTRL, ret = regmap_set_bits(info->regmap, MP2629_REG_ADC_CTRL,
MP2629_ADC_START | MP2629_ADC_CONTINUOUS,
MP2629_ADC_START | MP2629_ADC_CONTINUOUS); MP2629_ADC_START | MP2629_ADC_CONTINUOUS);
if (ret) { if (ret) {
dev_err(dev, "adc enable fail: %d\n", ret); dev_err(dev, "adc enable fail: %d\n", ret);
@ -163,10 +162,9 @@ fail_map_unregister:
iio_map_array_unregister(indio_dev); iio_map_array_unregister(indio_dev);
fail_disable: fail_disable:
regmap_update_bits(info->regmap, MP2629_REG_ADC_CTRL, regmap_clear_bits(info->regmap, MP2629_REG_ADC_CTRL,
MP2629_ADC_CONTINUOUS, 0); MP2629_ADC_CONTINUOUS);
regmap_update_bits(info->regmap, MP2629_REG_ADC_CTRL, regmap_clear_bits(info->regmap, MP2629_REG_ADC_CTRL, MP2629_ADC_START);
MP2629_ADC_START, 0);
return ret; return ret;
} }
@ -180,10 +178,9 @@ static void mp2629_adc_remove(struct platform_device *pdev)
iio_map_array_unregister(indio_dev); iio_map_array_unregister(indio_dev);
regmap_update_bits(info->regmap, MP2629_REG_ADC_CTRL, regmap_clear_bits(info->regmap, MP2629_REG_ADC_CTRL,
MP2629_ADC_CONTINUOUS, 0); MP2629_ADC_CONTINUOUS);
regmap_update_bits(info->regmap, MP2629_REG_ADC_CTRL, regmap_clear_bits(info->regmap, MP2629_REG_ADC_CTRL, MP2629_ADC_START);
MP2629_ADC_START, 0);
} }
static const struct of_device_id mp2629_adc_of_match[] = { static const struct of_device_id mp2629_adc_of_match[] = {