kevin/linux
1
Fork 0
Code

PM: sleep: Remove obsolete comment from unlock_system_sleep()

Browse Source 
With the freezer changes introduced by commit f5d39b0208
("freezer,sched: Rewrite core freezer logic"), the comment in
unlock_system_sleep() has become obsolete, there is no need to
retain it.

Signed-off-by: Kevin Hao <haokexin@gmail.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
Kevin Hao 2023-12-20 08:35:35 +08:00 committed by Rafael J. Wysocki
parent 4bbf0b6a64
commit e0f4bd26e2
1 changed files with 0 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
kernel/power/main.c
View File

@ -60,22 +60,6 @@ EXPORT_SYMBOL_GPL(lock_system_sleep);
void unlock_system_sleep(unsigned int flags) void unlock_system_sleep(unsigned int flags)
{ {
/*
* Don't use freezer_count() because we don't want the call to
* try_to_freeze() here.
*
* Reason:
* Fundamentally, we just don't need it, because freezing condition
* doesn't come into effect until we release the
* system_transition_mutex lock, since the freezer always works with
* system_transition_mutex held.
*
* More importantly, in the case of hibernation,
* unlock_system_sleep() gets called in snapshot_read() and
* snapshot_write() when the freezing condition is still in effect.
* Which means, if we use try_to_freeze() here, it would make them
* enter the refrigerator, thus causing hibernation to lockup.
*/
if (!(flags & PF_NOFREEZE)) if (!(flags & PF_NOFREEZE))
current->flags &= ~PF_NOFREEZE; current->flags &= ~PF_NOFREEZE;
mutex_unlock(&system_transition_mutex); mutex_unlock(&system_transition_mutex);