kevin/linux
1
Fork 0
Code

selftests/watchdog-test: Fix system accidentally reset after watchdog-test

Browse Source 
When running watchdog-test with 'make run_tests', the watchdog-test will
be terminated by a timeout signal(SIGTERM) due to the test timemout.

And then, a system reboot would happen due to watchdog not stop. see
the dmesg as below:
```
[ 1367.185172] watchdog: watchdog0: watchdog did not stop!
```

Fix it by registering more signals(including SIGTERM) in watchdog-test,
where its signal handler will stop the watchdog.

After that
 # timeout 1 ./watchdog-test
 Watchdog Ticking Away!
 .
 Stopping watchdog ticks...

Link: https://lore.kernel.org/all/20241029031324.482800-1-lizhijian@fujitsu.com/
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
This commit is contained in:
Li Zhijian 2024-10-29 11:13:24 +08:00 committed by Shuah Khan
parent 722d89c34c
commit dc1308bee1
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/testing/selftests/watchdog/watchdog-test.c
View File

@ -334,7 +334,13 @@ int main(int argc, char *argv[])
printf("Watchdog Ticking Away!\n");
/*
* Register the signals
*/
signal(SIGINT, term);
signal(SIGTERM, term);
signal(SIGKILL, term);
signal(SIGQUIT, term);
while (1) {
keep_alive();