kevin/linux
1
Fork 0
Code

media: v4l2-ctrls: Return handler error in creating new fwnode properties

Browse Source 
If the control handler is in an error state, return that error immediately
in v4l2_ctrl_new_fwnode_properties(). Effectively the change here is that
the same error code (handler's error) is returned in all cases instead of
possibly returning -EINVAL.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
This commit is contained in:
Sakari Ailus 2024-04-12 15:56:49 +03:00 committed by Hans Verkuil
parent e490d3ee39
commit d9134bd7bb
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/media/v4l2-core/v4l2-ctrls-core.c
View File

@ -2567,6 +2567,9 @@ int v4l2_ctrl_new_fwnode_properties(struct v4l2_ctrl_handler *hdl,
const struct v4l2_ctrl_ops *ctrl_ops, const struct v4l2_ctrl_ops *ctrl_ops,
const struct v4l2_fwnode_device_properties *p) const struct v4l2_fwnode_device_properties *p)
{ {
if (hdl->error)
return hdl->error;
if (p->orientation != V4L2_FWNODE_PROPERTY_UNSET) { if (p->orientation != V4L2_FWNODE_PROPERTY_UNSET) {
u32 orientation_ctrl; u32 orientation_ctrl;