kevin/linux
1
Fork 0
Code

mailbox: qcom-ipcc: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
This commit is contained in:
Uwe Kleine-König 2023-12-27 22:02:36 +01:00 committed by Jassi Brar
parent ce42b93c63
commit d3a0021c41
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/mailbox/qcom-ipcc.c
View File

@ -326,14 +326,12 @@ err_mbox:
return ret; return ret;
} }
static int qcom_ipcc_remove(struct platform_device *pdev) static void qcom_ipcc_remove(struct platform_device *pdev)
{ {
struct qcom_ipcc *ipcc = platform_get_drvdata(pdev); struct qcom_ipcc *ipcc = platform_get_drvdata(pdev);
disable_irq_wake(ipcc->irq); disable_irq_wake(ipcc->irq);
irq_domain_remove(ipcc->irq_domain); irq_domain_remove(ipcc->irq_domain);
return 0;
} }
static const struct of_device_id qcom_ipcc_of_match[] = { static const struct of_device_id qcom_ipcc_of_match[] = {
@ -348,7 +346,7 @@ static const struct dev_pm_ops qcom_ipcc_dev_pm_ops = {
static struct platform_driver qcom_ipcc_driver = { static struct platform_driver qcom_ipcc_driver = {
.probe = qcom_ipcc_probe, .probe = qcom_ipcc_probe,
.remove = qcom_ipcc_remove, .remove_new = qcom_ipcc_remove,
.driver = { .driver = {
.name = "qcom-ipcc", .name = "qcom-ipcc",
.of_match_table = qcom_ipcc_of_match, .of_match_table = qcom_ipcc_of_match,