kevin/linux
1
Fork 0
Code

net: xscale: Drop unused PHY number

Browse Source 
For some cargoculted reason on incomplete cleanup, we have a
PHY number which refers to nothing and gives confusing messages
about PHY 0 on all ports.

Print the name of the actual PHY device instead.

Reported-by: Howard Harte <hharte@magicandroidapps.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20231028-ixp4xx-eth-id-v1-1-57be486d7f0f@linaro.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Linus Walleij 2023-10-28 22:48:35 +02:00 committed by Jakub Kicinski
parent 2b7ac0c87d
commit d280783c3a
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/ethernet/xscale/ixp4xx_eth.c
View File

@ -163,7 +163,6 @@ typedef void buffer_t;
/* Information about built-in Ethernet MAC interfaces */ /* Information about built-in Ethernet MAC interfaces */
struct eth_plat_info { struct eth_plat_info {
u8 phy; /* MII PHY ID, 0 - 31 */
u8 rxq; /* configurable, currently 0 - 31 only */ u8 rxq; /* configurable, currently 0 - 31 only */
u8 txreadyq; u8 txreadyq;
u8 hwaddr[ETH_ALEN]; u8 hwaddr[ETH_ALEN];
@ -1583,7 +1582,7 @@ static int ixp4xx_eth_probe(struct platform_device *pdev)
if ((err = register_netdev(ndev))) if ((err = register_netdev(ndev)))
goto err_phy_dis; goto err_phy_dis;
netdev_info(ndev, "%s: MII PHY %i on %s\n", ndev->name, plat->phy, netdev_info(ndev, "%s: MII PHY %s on %s\n", ndev->name, phydev_name(phydev),
npe_name(port->npe)); npe_name(port->npe));
return 0; return 0;