kevin/linux
1
Fork 0
Code

mailbox: qcom-apcs-ipc: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
This commit is contained in:
Uwe Kleine-König 2023-12-27 22:02:35 +01:00 committed by Jassi Brar
parent 67785923d3
commit ce42b93c63
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/mailbox/qcom-apcs-ipc-mailbox.c
View File

@ -129,14 +129,12 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int qcom_apcs_ipc_remove(struct platform_device *pdev) static void qcom_apcs_ipc_remove(struct platform_device *pdev)
{ {
struct qcom_apcs_ipc *apcs = platform_get_drvdata(pdev); struct qcom_apcs_ipc *apcs = platform_get_drvdata(pdev);
struct platform_device *clk = apcs->clk; struct platform_device *clk = apcs->clk;
platform_device_unregister(clk); platform_device_unregister(clk);
return 0;
} }
/* .data is the offset of the ipc register within the global block */ /* .data is the offset of the ipc register within the global block */
@ -169,7 +167,7 @@ MODULE_DEVICE_TABLE(of, qcom_apcs_ipc_of_match);
static struct platform_driver qcom_apcs_ipc_driver = { static struct platform_driver qcom_apcs_ipc_driver = {
.probe = qcom_apcs_ipc_probe, .probe = qcom_apcs_ipc_probe,
.remove = qcom_apcs_ipc_remove, .remove_new = qcom_apcs_ipc_remove,
.driver = { .driver = {
.name = "qcom_apcs_ipc", .name = "qcom_apcs_ipc",
.of_match_table = qcom_apcs_ipc_of_match, .of_match_table = qcom_apcs_ipc_of_match,