kevin/linux
1
Fork 0
Code

ASoC: max98388: Fix missing increment of variable slot_found

Browse Source 
The variable slot_found is being initialized to zero and inside
a for-loop is being checked if it's reached MAX_NUM_CH, however,
this is currently impossible since slot_found is never changed.
In a previous loop a similar coding pattern is used and slot_found
is being incremented. It appears the increment of slot_found is
missing from the loop, so fix the code by adding in the increment.

Fixes: 6a8e1d46f0 ("ASoC: max98388: add amplifier driver")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://patch.msgid.link/20241010182032.776280-1-colin.i.king@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Colin Ian King 2024-10-10 19:20:32 +01:00 committed by Mark Brown
parent 182fff3a2a
commit ca2803fadf
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
sound/soc/codecs/max98388.c
View File

@ -763,6 +763,7 @@ static int max98388_dai_tdm_slot(struct snd_soc_dai *dai,
addr = MAX98388_R2044_PCM_TX_CTRL1 + (cnt / 8); addr = MAX98388_R2044_PCM_TX_CTRL1 + (cnt / 8);
bits = cnt % 8; bits = cnt % 8;
regmap_update_bits(max98388->regmap, addr, bits, bits); regmap_update_bits(max98388->regmap, addr, bits, bits);
slot_found++;
if (slot_found >= MAX_NUM_CH) if (slot_found >= MAX_NUM_CH)
break; break;
} }