kevin/linux
1
Fork 0
Code

genirq/proc: Correctly set file permissions for affinity control files

Browse Source 
The kernel already knows at the time of interrupt allocation whether
affinity of an interrupt can be controlled by userspace or not.

It still creates all related procfs control files with read/write
permissions. That's inconsistent and non-intuitive for system
administrators and tools.

Therefore set the file permissions to read-only for such interrupts.

[ tglx: Massage change log, fixed UP build ]

Signed-off-by: Jeff Xie <jeff.xie@linux.dev>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20240825131911.107119-1-jeff.xie@linux.dev
This commit is contained in:
Jeff Xie 2024-08-25 21:19:11 +08:00 committed by Thomas Gleixner
parent 64b6d1d7a8
commit c7718e5c76
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
kernel/irq/proc.c
View File

@ -362,8 +362,13 @@ void register_irq_proc(unsigned int irq, struct irq_desc *desc)
goto out_unlock; goto out_unlock;
#ifdef CONFIG_SMP #ifdef CONFIG_SMP
umode_t umode = S_IRUGO;
if (irq_can_set_affinity_usr(desc->irq_data.irq))
umode |= S_IWUSR;
/* create /proc/irq/<irq>/smp_affinity */ /* create /proc/irq/<irq>/smp_affinity */
proc_create_data("smp_affinity", 0644, desc->dir, proc_create_data("smp_affinity", umode, desc->dir,
&irq_affinity_proc_ops, irqp); &irq_affinity_proc_ops, irqp);
/* create /proc/irq/<irq>/affinity_hint */ /* create /proc/irq/<irq>/affinity_hint */
@ -371,7 +376,7 @@ void register_irq_proc(unsigned int irq, struct irq_desc *desc)
irq_affinity_hint_proc_show, irqp); irq_affinity_hint_proc_show, irqp);
/* create /proc/irq/<irq>/smp_affinity_list */ /* create /proc/irq/<irq>/smp_affinity_list */
proc_create_data("smp_affinity_list", 0644, desc->dir, proc_create_data("smp_affinity_list", umode, desc->dir,
&irq_affinity_list_proc_ops, irqp); &irq_affinity_list_proc_ops, irqp);
proc_create_single_data("node", 0444, desc->dir, irq_node_proc_show, proc_create_single_data("node", 0444, desc->dir, irq_node_proc_show,