kevin/linux
1
Fork 0
Code

accel/habanalabs/gaudi2: revise return value handling in gaudi2_hbm_sei_handle_read_err()

Browse Source 
The return value in gaudi2_hbm_sei_handle_read_err() is boolean and not
a bitmask, so there is need for "|= true".
In addition, rename the 'rc' variable, as no "return code" is returned
here but an indication if a hard reset is required.

Signed-off-by: Tomer Tayar <ttayar@habana.ai>
Reviewed-by: Ofir Bitton <obitton@habana.ai>
Signed-off-by: Ofir Bitton <obitton@habana.ai>
This commit is contained in:
Tomer Tayar 2024-03-10 12:03:22 +02:00 committed by Ofir Bitton
parent 990e0d91bf
commit c754bcf9dd
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/accel/habanalabs/gaudi2/gaudi2.c
View File

@ -9263,8 +9263,8 @@ static int gaudi2_handle_mmu_spi_sei_err(struct hl_device *hdev, u16 event_type,
static bool gaudi2_hbm_sei_handle_read_err(struct hl_device *hdev, static bool gaudi2_hbm_sei_handle_read_err(struct hl_device *hdev,
struct hl_eq_hbm_sei_read_err_intr_info *rd_err_data, u32 err_cnt) struct hl_eq_hbm_sei_read_err_intr_info *rd_err_data, u32 err_cnt)
{ {
bool require_hard_reset = false;
u32 addr, beat, beat_shift; u32 addr, beat, beat_shift;
bool rc = false;
dev_err_ratelimited(hdev->dev, dev_err_ratelimited(hdev->dev,
"READ ERROR count: ECC SERR: %d, ECC DERR: %d, RD_PARITY: %d\n", "READ ERROR count: ECC SERR: %d, ECC DERR: %d, RD_PARITY: %d\n",
@ -9296,7 +9296,7 @@ static bool gaudi2_hbm_sei_handle_read_err(struct hl_device *hdev,
beat, beat,
le32_to_cpu(rd_err_data->dbg_rd_err_dm), le32_to_cpu(rd_err_data->dbg_rd_err_dm),
le32_to_cpu(rd_err_data->dbg_rd_err_syndrome)); le32_to_cpu(rd_err_data->dbg_rd_err_syndrome));
rc |= true; require_hard_reset = true;
} }
beat_shift = beat * HBM_RD_ERR_BEAT_SHIFT; beat_shift = beat * HBM_RD_ERR_BEAT_SHIFT;
@ -9309,7 +9309,7 @@ static bool gaudi2_hbm_sei_handle_read_err(struct hl_device *hdev,
(le32_to_cpu(rd_err_data->dbg_rd_err_misc) & (le32_to_cpu(rd_err_data->dbg_rd_err_misc) &
(HBM_RD_ERR_PAR_DATA_BEAT0_MASK << beat_shift)) >> (HBM_RD_ERR_PAR_DATA_BEAT0_MASK << beat_shift)) >>
(HBM_RD_ERR_PAR_DATA_BEAT0_SHIFT + beat_shift)); (HBM_RD_ERR_PAR_DATA_BEAT0_SHIFT + beat_shift));
rc |= true; require_hard_reset = true;
} }
dev_err_ratelimited(hdev->dev, "Beat%d DQ data:\n", beat); dev_err_ratelimited(hdev->dev, "Beat%d DQ data:\n", beat);
@ -9319,7 +9319,7 @@ static bool gaudi2_hbm_sei_handle_read_err(struct hl_device *hdev,
le32_to_cpu(rd_err_data->dbg_rd_err_data[beat * 2 + 1])); le32_to_cpu(rd_err_data->dbg_rd_err_data[beat * 2 + 1]));
} }
return rc; return require_hard_reset;
} }
static void gaudi2_hbm_sei_print_wr_par_info(struct hl_device *hdev, static void gaudi2_hbm_sei_print_wr_par_info(struct hl_device *hdev,