kevin/linux
1
Fork 0
Code

ext4: fix error pointer dereference in ext4_mb_load_buddy_gfp()

Browse Source 
This code calls folio_put() on an error pointer which will lead to a
crash.  Check for both error pointers and NULL pointers before calling
folio_put().

Fixes: 5eea586b47 ("ext4: convert bd_buddy_page to bd_buddy_folio")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/eaafa1d9-a61c-4af4-9f97-d3ad72c60200@moroto.mountain
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
This commit is contained in:
Dan Carpenter 2024-05-10 18:22:53 +03:00 committed by Theodore Ts'o
parent 26770a717c
commit c6a6c9694a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/ext4/mballoc.c
View File

@ -1717,7 +1717,7 @@ ext4_mb_load_buddy_gfp(struct super_block *sb, ext4_group_t group,
return 0; return 0;
err: err:
if (folio) if (!IS_ERR_OR_NULL(folio))
folio_put(folio); folio_put(folio);
if (e4b->bd_bitmap_folio) if (e4b->bd_bitmap_folio)
folio_put(e4b->bd_bitmap_folio); folio_put(e4b->bd_bitmap_folio);