kevin/linux
1
Fork 0
Code

Revert "list: test: fix tests for list_cut_position()"

Browse Source 
This reverts commit e620799c41.

The commit introduces unit test failures.

     Expected cur == &entries[i], but
         cur == 0000037fffadfd80
         &entries[i] == 0000037fffadfd60
     # list_test_list_cut_position: pass:0 fail:1 skip:0 total:1
     not ok 21 list_test_list_cut_position
     # list_test_list_cut_before: EXPECTATION FAILED at lib/list-test.c:444
     Expected cur == &entries[i], but
         cur == 0000037fffa9fd70
         &entries[i] == 0000037fffa9fd60
     # list_test_list_cut_before: EXPECTATION FAILED at lib/list-test.c:444
     Expected cur == &entries[i], but
         cur == 0000037fffa9fd80
         &entries[i] == 0000037fffa9fd70

Revert it.

Link: https://lkml.kernel.org/r/20240922150507.553814-1-linux@roeck-us.net
Fixes: e620799c41 ("list: test: fix tests for list_cut_position()")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Cc: I Hsin Cheng <richard120310@gmail.com>
Cc: David Gow <davidgow@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Guenter Roeck 2024-09-22 08:05:07 -07:00 committed by Andrew Morton
parent f30beffd97
commit c509f67df3
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/list-test.c
View File

@ -408,13 +408,10 @@ static void list_test_list_cut_position(struct kunit *test)
KUNIT_EXPECT_EQ(test, i, 2); KUNIT_EXPECT_EQ(test, i, 2);
i = 0;
list_for_each(cur, &list1) { list_for_each(cur, &list1) {
KUNIT_EXPECT_PTR_EQ(test, cur, &entries[i]); KUNIT_EXPECT_PTR_EQ(test, cur, &entries[i]);
i++; i++;
} }
KUNIT_EXPECT_EQ(test, i, 1);
} }
static void list_test_list_cut_before(struct kunit *test) static void list_test_list_cut_before(struct kunit *test)
@ -439,13 +436,10 @@ static void list_test_list_cut_before(struct kunit *test)
KUNIT_EXPECT_EQ(test, i, 1); KUNIT_EXPECT_EQ(test, i, 1);
i = 0;
list_for_each(cur, &list1) { list_for_each(cur, &list1) {
KUNIT_EXPECT_PTR_EQ(test, cur, &entries[i]); KUNIT_EXPECT_PTR_EQ(test, cur, &entries[i]);
i++; i++;
} }
KUNIT_EXPECT_EQ(test, i, 2);
} }
static void list_test_list_splice(struct kunit *test) static void list_test_list_splice(struct kunit *test)