kevin/linux
1
Fork 0
Code

mm/damon/lru_sort: adjust local variable to dynamic allocation

Browse Source 
When KASAN is enabled and built with clang:
    mm/damon/lru_sort.c:199:12: error: stack frame size (2328) exceeds
limit (2048) in 'damon_lru_sort_apply_parameters' [-Werror,-Wframe-larger-than]
    static int damon_lru_sort_apply_parameters(void)
               ^
    1 error generated.

This is because damon_lru_sort_quota contains a large array, and
assigning this variable to a local variable causes a large amount of
stack space to be occupied.

So adjust local variable to dynamic allocation.

Link: https://lkml.kernel.org/r/20240723035513.20153-1-flyingpeng@tencent.com
Signed-off-by: Peng Hao <flyingpeng@tencent.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Peng Hao 2024-07-23 11:55:13 +08:00 committed by Andrew Morton
parent c2a967f6ab
commit c39542732a
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
mm/damon/lru_sort.c
View File

@ -148,12 +148,17 @@ static struct damon_target *target;
static struct damos *damon_lru_sort_new_scheme( static struct damos *damon_lru_sort_new_scheme(
struct damos_access_pattern *pattern, enum damos_action action) struct damos_access_pattern *pattern, enum damos_action action)
{ {
struct damos_quota quota = damon_lru_sort_quota; struct damos *damos;
struct damos_quota *quota = kmemdup(&damon_lru_sort_quota,
sizeof(damon_lru_sort_quota), GFP_KERNEL);
if (!quota)
return NULL;
/* Use half of total quota for hot/cold pages sorting */ /* Use half of total quota for hot/cold pages sorting */
quota.ms = quota.ms / 2; quota->ms = quota->ms / 2;
return damon_new_scheme( damos = damon_new_scheme(
/* find the pattern, and */ /* find the pattern, and */
pattern, pattern,
/* (de)prioritize on LRU-lists */ /* (de)prioritize on LRU-lists */
@ -161,10 +166,12 @@ static struct damos *damon_lru_sort_new_scheme(
/* for each aggregation interval */ /* for each aggregation interval */
0, 0,
/* under the quota. */ /* under the quota. */
&quota, quota,
/* (De)activate this according to the watermarks. */ /* (De)activate this according to the watermarks. */
&damon_lru_sort_wmarks, &damon_lru_sort_wmarks,
NUMA_NO_NODE); NUMA_NO_NODE);
kfree(quota);
return damos;
} }
/* Create a DAMON-based operation scheme for hot memory regions */ /* Create a DAMON-based operation scheme for hot memory regions */