kevin/linux
1
Fork 0
Code

crypto: spacc - Fix uninitialized variable in spacc_aead_process()

Browse Source 
Smatch complains that:

    drivers/crypto/dwc-spacc/spacc_aead.c:1031 spacc_aead_process()
    error: uninitialized symbol 'ptaadsize'.

This could happen if, for example, tctx->mode was CRYPTO_MODE_NULL and
req->cryptlen was less than icvremove.

Fixes: 06af76b46c ("crypto: spacc - Add SPAcc aead support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Dan Carpenter 2024-08-15 14:20:04 +03:00 committed by Herbert Xu
parent f036dd5664
commit c32f08d024
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/crypto/dwc-spacc/spacc_aead.c
View File

@ -808,7 +808,7 @@ static int spacc_aead_process(struct aead_request *req, u64 seq, int encrypt)
u32 dstoff;
int icvremove;
int ivaadsize;
int ptaadsize;
int ptaadsize = 0;
int iv_to_context;
int spacc_proc_len;
u32 spacc_icv_offset = 0;
@ -959,8 +959,6 @@ static int spacc_aead_process(struct aead_request *req, u64 seq, int encrypt)
tctx->mode == CRYPTO_MODE_NULL) {
if (req->cryptlen >= icvremove)
ptaadsize = req->cryptlen - icvremove;
} else {
ptaadsize = 0;
}
/* Calculate and set the below, important parameters