kevin/linux
1
Fork 0
Code

ALSA: hda: intel-sdw-acpi: fix usage of device_get_named_child_node()

Browse Source 
The documentation for device_get_named_child_node() mentions this
important point:

"
The caller is responsible for calling fwnode_handle_put() on the
returned fwnode pointer.
"

Add fwnode_handle_put() to avoid a leaked reference.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fixes: 08c2a4bc9f ("ALSA: hda: move Intel SoundWire ACPI scan to dedicated module")
Message-ID: <20240426152731.38420-1-pierre-louis.bossart@linux.intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Pierre-Louis Bossart 2024-04-26 10:27:31 -05:00 committed by Takashi Iwai
parent 79ac4c1443
commit c158cf9147
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sound/hda/intel-sdw-acpi.c
View File

@ -45,6 +45,8 @@ static bool is_link_enabled(struct fwnode_handle *fw_node, u8 idx)
"intel-quirk-mask", "intel-quirk-mask",
&quirk_mask); &quirk_mask);
fwnode_handle_put(link);
if (quirk_mask & SDW_INTEL_QUIRK_MASK_BUS_DISABLE) if (quirk_mask & SDW_INTEL_QUIRK_MASK_BUS_DISABLE)
return false; return false;