kevin/linux
1
Fork 0
Code

MIPS: SGI-IP27: use WARN_ON() output

Browse Source 
WARN_ON() propagates the result of conditional expression, and it can be
used to return early in the following expression in the arch_init_irq().

This is a no-op cleanup, except that compiler may optimize the error paths
better because WARN_ON() implies 'unlikely()'.

Signed-off-by: Yury Norov <yury.norov@gmail.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
This commit is contained in:
Yury Norov 2024-04-16 10:37:11 -07:00 committed by Thomas Bogendoerfer
parent 156e6498fc
commit bfe4ab93c8
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
arch/mips/sgi-ip27/ip27-irq.c
View File

@ -289,13 +289,12 @@ void __init arch_init_irq(void)
bitmap_set(hub_irq_map, NI_BRDCAST_ERR_A, MSC_PANIC_INTR - NI_BRDCAST_ERR_A + 1); bitmap_set(hub_irq_map, NI_BRDCAST_ERR_A, MSC_PANIC_INTR - NI_BRDCAST_ERR_A + 1);
fn = irq_domain_alloc_named_fwnode("HUB"); fn = irq_domain_alloc_named_fwnode("HUB");
WARN_ON(fn == NULL); if (WARN_ON(fn == NULL))
if (!fn)
return; return;
domain = irq_domain_create_linear(fn, IP27_HUB_IRQ_COUNT, domain = irq_domain_create_linear(fn, IP27_HUB_IRQ_COUNT,
&hub_domain_ops, NULL); &hub_domain_ops, NULL);
WARN_ON(domain == NULL); if (WARN_ON(domain == NULL))
if (!domain)
return; return;
irq_set_default_host(domain); irq_set_default_host(domain);