kevin/linux
1
Fork 0
Code

mtd: rawnand: mxc: use 'time_left' variable with wait_for_completion_timeout()

Browse Source 
There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_timeout() causing patterns like:

	timeout = wait_for_completion_timeout(...)
	if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20240604212919.5038-5-wsa+renesas@sang-engineering.com
This commit is contained in:
Wolfram Sang 2024-06-04 23:29:20 +02:00 committed by Miquel Raynal
parent cbbfb0b4f8
commit bf66d81975
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/mtd/nand/raw/mxc_nand.c
View File

@ -457,14 +457,14 @@ static int wait_op_done(struct mxc_nand_host *host, int useirq)
return 0; return 0;
if (useirq) { if (useirq) {
unsigned long timeout; unsigned long time_left;
reinit_completion(&host->op_completion); reinit_completion(&host->op_completion);
irq_control(host, 1); irq_control(host, 1);
timeout = wait_for_completion_timeout(&host->op_completion, HZ); time_left = wait_for_completion_timeout(&host->op_completion, HZ);
if (!timeout && !host->devtype_data->check_int(host)) { if (!time_left && !host->devtype_data->check_int(host)) {
dev_dbg(host->dev, "timeout waiting for irq\n"); dev_dbg(host->dev, "timeout waiting for irq\n");
ret = -ETIMEDOUT; ret = -ETIMEDOUT;
} }