kevin/linux
1
Fork 0
Code

cpuidle: menu: Cleanup after loadavg removal

Browse Source 
The performance impact of loadavg was removed with commit a7fe5190c0
("cpuidle: menu: Remove get_loadavg() from the performance multiplier")
With only iowait remaining the description can be simplified, remove
also the no longer needed includes.

Signed-off-by: Christian Loehle <christian.loehle@arm.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
Christian Loehle 2024-06-04 11:55:29 +01:00 committed by Rafael J. Wysocki
parent 17c4fc386b
commit bf18311384
1 changed files with 5 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/cpuidle/governors/menu.c
View File

@ -14,8 +14,6 @@
#include <linux/ktime.h> #include <linux/ktime.h>
#include <linux/hrtimer.h> #include <linux/hrtimer.h>
#include <linux/tick.h> #include <linux/tick.h>
#include <linux/sched.h>
#include <linux/sched/loadavg.h>
#include <linux/sched/stat.h> #include <linux/sched/stat.h>
#include <linux/math64.h> #include <linux/math64.h>
@ -95,16 +93,11 @@
* state, and thus the less likely a busy CPU will hit such a deep * state, and thus the less likely a busy CPU will hit such a deep
* C state. * C state.
* *
* Two factors are used in determing this multiplier: * Currently there is only one value determining the factor:
* a value of 10 is added for each point of "per cpu load average" we have. * 10 points are added for each process that is waiting for IO on this CPU.
* a value of 5 points is added for each process that is waiting for * (This value was experimentally determined.)
* IO on this CPU. * Utilization is no longer a factor as it was shown that it never contributed
* (these values are experimentally determined) * significantly to the performance multiplier in the first place.
*
* The load average factor gives a longer term (few seconds) input to the
* decision, while the iowait value gives a cpu local instantanious input.
* The iowait factor may look low, but realize that this is also already
* represented in the system load average.
* *
*/ */