kevin/linux
1
Fork 0
Code

spi: oc-tiny: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230303172041.2103336-49-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Uwe Kleine-König 2023-03-03 18:20:02 +01:00 committed by Mark Brown
parent 2dd82e32c2
commit bdffa602d7
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/spi/spi-oc-tiny.c
View File

@ -271,14 +271,13 @@ exit:
return err; return err;
} }
static int tiny_spi_remove(struct platform_device *pdev) static void tiny_spi_remove(struct platform_device *pdev)
{ {
struct tiny_spi *hw = platform_get_drvdata(pdev); struct tiny_spi *hw = platform_get_drvdata(pdev);
struct spi_master *master = hw->bitbang.master; struct spi_master *master = hw->bitbang.master;
spi_bitbang_stop(&hw->bitbang); spi_bitbang_stop(&hw->bitbang);
spi_master_put(master); spi_master_put(master);
return 0;
} }
#ifdef CONFIG_OF #ifdef CONFIG_OF
@ -291,7 +290,7 @@ MODULE_DEVICE_TABLE(of, tiny_spi_match);
static struct platform_driver tiny_spi_driver = { static struct platform_driver tiny_spi_driver = {
.probe = tiny_spi_probe, .probe = tiny_spi_probe,
.remove = tiny_spi_remove, .remove_new = tiny_spi_remove,
.driver = { .driver = {
.name = DRV_NAME, .name = DRV_NAME,
.pm = NULL, .pm = NULL,