kevin/linux
1
Fork 0
Code

x86/platform/iris: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/adb9b0aca77d7aa8e54d0a664a4ee290834a60a1.1712732665.git.u.kleine-koenig@pengutronix.de
This commit is contained in:
Uwe Kleine-König 2024-04-10 09:16:51 +02:00 committed by Ingo Molnar
parent f87136c057
commit bcc0403eb4
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
arch/x86/platform/iris/iris.c
View File

@ -62,11 +62,10 @@ static int iris_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int iris_remove(struct platform_device *pdev) static void iris_remove(struct platform_device *pdev)
{ {
pm_power_off = old_pm_power_off; pm_power_off = old_pm_power_off;
printk(KERN_INFO "Iris power_off handler uninstalled.\n"); printk(KERN_INFO "Iris power_off handler uninstalled.\n");
return 0;
} }
static struct platform_driver iris_driver = { static struct platform_driver iris_driver = {
@ -74,7 +73,7 @@ static struct platform_driver iris_driver = {
.name = "iris", .name = "iris",
}, },
.probe = iris_probe, .probe = iris_probe,
.remove = iris_remove, .remove_new = iris_remove,
}; };
static struct resource iris_resources[] = { static struct resource iris_resources[] = {