kevin/linux
1
Fork 0
Code

Input: wistron_btns - use kmemdup_array instead of kmemdup for multiple allocation

Browse Source 
Let the kmemdup_array() take care about multiplication
and possible overflows.

Using kmemdup_array() is more appropriate and makes the code
easier to audit.

Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
Link: https://lore.kernel.org/r/20240826045253.3503-1-shenlichuan@vivo.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This commit is contained in:
Shen Lichuan 2024-08-26 12:52:53 +08:00 committed by Dmitry Torokhov
parent 6994d8b84b
commit b7ffc98a6a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/input/misc/wistron_btns.c
View File

@ -990,8 +990,8 @@ static int __init copy_keymap(void)
for (key = keymap; key->type != KE_END; key++)
length++;
new_keymap = kmemdup(keymap, length * sizeof(struct key_entry),
GFP_KERNEL);
new_keymap = kmemdup_array(keymap, length, sizeof(struct key_entry),
GFP_KERNEL);
if (!new_keymap)
return -ENOMEM;