kevin/linux
1
Fork 0
Code

crypto: spacc - Fix bounds checking on spacc->job[]

Browse Source 
This bounds checking is off by one.  The > should be >=.  The
spacc->job[] array is allocated in spacc_init() and it has
SPACC_MAX_JOBS elements.

Fixes: 8ebb14deef ("crypto: spacc - Enable SPAcc AUTODETECT")
Fixes: c8981d9230 ("crypto: spacc - Add SPAcc Skcipher support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Dan Carpenter 2024-08-15 00:11:51 +03:00 committed by Herbert Xu
parent 142a794bcf
commit b63483b37e
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/crypto/dwc-spacc/spacc_core.c
View File

@ -1024,7 +1024,7 @@ int spacc_set_operation(struct spacc_device *spacc, int handle, int op,
int ret = CRYPTO_OK; int ret = CRYPTO_OK;
struct spacc_job *job = NULL; struct spacc_job *job = NULL;
if (handle < 0 || handle > SPACC_MAX_JOBS) if (handle < 0 || handle >= SPACC_MAX_JOBS)
return -ENXIO; return -ENXIO;
job = &spacc->job[handle]; job = &spacc->job[handle];
@ -1105,7 +1105,7 @@ int spacc_packet_enqueue_ddt_ex(struct spacc_device *spacc, int use_jb,
struct spacc_job *job; struct spacc_job *job;
int ret = CRYPTO_OK, proc_len; int ret = CRYPTO_OK, proc_len;
if (job_idx < 0 || job_idx > SPACC_MAX_JOBS) if (job_idx < 0 || job_idx >= SPACC_MAX_JOBS)
return -ENXIO; return -ENXIO;
switch (prio) { switch (prio) {
@ -1331,7 +1331,7 @@ static int spacc_set_auxinfo(struct spacc_device *spacc, int jobid,
int ret = CRYPTO_OK; int ret = CRYPTO_OK;
struct spacc_job *job; struct spacc_job *job;
if (jobid < 0 || jobid > SPACC_MAX_JOBS) if (jobid < 0 || jobid >= SPACC_MAX_JOBS)
return -ENXIO; return -ENXIO;
job = &spacc->job[jobid]; job = &spacc->job[jobid];
@ -2364,7 +2364,7 @@ int spacc_set_key_exp(struct spacc_device *spacc, int job_idx)
struct spacc_ctx *ctx = NULL; struct spacc_ctx *ctx = NULL;
struct spacc_job *job = NULL; struct spacc_job *job = NULL;
if (job_idx < 0 || job_idx > SPACC_MAX_JOBS) { if (job_idx < 0 || job_idx >= SPACC_MAX_JOBS) {
pr_debug("ERR: Invalid Job id specified (out of range)\n"); pr_debug("ERR: Invalid Job id specified (out of range)\n");
return -ENXIO; return -ENXIO;
} }