kevin/linux
1
Fork 0
Code

crypto: lib/mpi - Use swap() in mpi_powm()

Browse Source 
Use existing swap() function rather than duplicating its implementation.

./lib/crypto/mpi/mpi-pow.c:211:11-12: WARNING opportunity for swap().
./lib/crypto/mpi/mpi-pow.c:239:12-13: WARNING opportunity for swap().

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9327
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Jiapeng Chong 2024-06-14 11:09:12 +08:00 committed by Herbert Xu
parent f0da7a231c
commit b44327ebc1
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/crypto/mpi/mpi-pow.c
View File

@ -176,7 +176,6 @@ int mpi_powm(MPI res, MPI base, MPI exp, MPI mod)
for (;;) {
while (c) {
mpi_ptr_t tp;
mpi_size_t xsize;
/*if (mpihelp_mul_n(xp, rp, rp, rsize) < 0) goto enomem */
@ -207,9 +206,7 @@ int mpi_powm(MPI res, MPI base, MPI exp, MPI mod)
xsize = msize;
}
tp = rp;
rp = xp;
xp = tp;
swap(rp, xp);
rsize = xsize;
if ((mpi_limb_signed_t) e < 0) {
@ -235,9 +232,7 @@ int mpi_powm(MPI res, MPI base, MPI exp, MPI mod)
xsize = msize;
}
tp = rp;
rp = xp;
xp = tp;
swap(rp, xp);
rsize = xsize;
}
e <<= 1;