kevin/linux
1
Fork 0
Code

vfs: correct the comments of vfs_*() helpers

Browse Source 
correct the comments of vfs_*() helpers in fs/namei.c, including:
1. vfs_create()
2. vfs_mknod()
3. vfs_mkdir()
4. vfs_rmdir()
5. vfs_symlink()

All of them come from the same commit:
6521f89170 "namei: prepare for idmapped mounts"

The @dentry is actually the dentry of child directory rather than
base directory(parent directory), and thus the @dir has to be
modified due to the change of @dentry.

Signed-off-by: Congjie Zhou <zcjie0802@qq.com>
Link: https://lore.kernel.org/r/tencent_2FCF6CC9E10DC8A27AE58A5A0FE4FCE96D0A@qq.com
Signed-off-by: Christian Brauner <brauner@kernel.org>
This commit is contained in:
Congjie Zhou 2024-07-19 00:25:45 +08:00 committed by Christian Brauner
parent 5bc9ad78c2
commit b40c8e7a03
No known key found for this signature in database
GPG Key ID: 91C61BC06578DCA2
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
fs/namei.c
View File

@ -3248,9 +3248,9 @@ static inline umode_t vfs_prepare_mode(struct mnt_idmap *idmap,
/** /**
* vfs_create - create new file * vfs_create - create new file
* @idmap: idmap of the mount the inode was found from * @idmap: idmap of the mount the inode was found from
* @dir: inode of @dentry * @dir: inode of the parent directory
* @dentry: pointer to dentry of the base directory * @dentry: dentry of the child file
* @mode: mode of the new file * @mode: mode of the child file
* @want_excl: whether the file must not yet exist * @want_excl: whether the file must not yet exist
* *
* Create a new file. * Create a new file.
@ -4047,9 +4047,9 @@ EXPORT_SYMBOL(user_path_create);
/** /**
* vfs_mknod - create device node or file * vfs_mknod - create device node or file
* @idmap: idmap of the mount the inode was found from * @idmap: idmap of the mount the inode was found from
* @dir: inode of @dentry * @dir: inode of the parent directory
* @dentry: pointer to dentry of the base directory * @dentry: dentry of the child device node
* @mode: mode of the new device node or file * @mode: mode of the child device node
* @dev: device number of device to create * @dev: device number of device to create
* *
* Create a device node or file. * Create a device node or file.
@ -4174,9 +4174,9 @@ SYSCALL_DEFINE3(mknod, const char __user *, filename, umode_t, mode, unsigned, d
/** /**
* vfs_mkdir - create directory * vfs_mkdir - create directory
* @idmap: idmap of the mount the inode was found from * @idmap: idmap of the mount the inode was found from
* @dir: inode of @dentry * @dir: inode of the parent directory
* @dentry: pointer to dentry of the base directory * @dentry: dentry of the child directory
* @mode: mode of the new directory * @mode: mode of the child directory
* *
* Create a directory. * Create a directory.
* *
@ -4256,8 +4256,8 @@ SYSCALL_DEFINE2(mkdir, const char __user *, pathname, umode_t, mode)
/** /**
* vfs_rmdir - remove directory * vfs_rmdir - remove directory
* @idmap: idmap of the mount the inode was found from * @idmap: idmap of the mount the inode was found from
* @dir: inode of @dentry * @dir: inode of the parent directory
* @dentry: pointer to dentry of the base directory * @dentry: dentry of the child directory
* *
* Remove a directory. * Remove a directory.
* *
@ -4537,8 +4537,8 @@ SYSCALL_DEFINE1(unlink, const char __user *, pathname)
/** /**
* vfs_symlink - create symlink * vfs_symlink - create symlink
* @idmap: idmap of the mount the inode was found from * @idmap: idmap of the mount the inode was found from
* @dir: inode of @dentry * @dir: inode of the parent directory
* @dentry: pointer to dentry of the base directory * @dentry: dentry of the child symlink file
* @oldname: name of the file to link to * @oldname: name of the file to link to
* *
* Create a symlink. * Create a symlink.