kevin/linux
1
Fork 0
Code

sched/rt, dl: Convert functions to return bool

Browse Source 
{rt, realtime, dl}_{task, prio}() functions' return value is actually
a bool. Convert their return type to reflect that.

Suggested-by: "Steven Rostedt (Google)" <rostedt@goodmis.org>
Signed-off-by: Qais Yousef <qyousef@layalina.io>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Reviewed-by: "Steven Rostedt (Google)" <rostedt@goodmis.org>
Reviewed-by: Metin Kaya <metin.kaya@arm.com>
Link: https://lore.kernel.org/r/20240610192018.1567075-3-qyousef@layalina.io
This commit is contained in:
Qais Yousef 2024-06-10 20:20:17 +01:00 committed by Peter Zijlstra
parent 130fd056dd
commit b166af3db7
2 changed files with 9 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
include/linux/sched/deadline.h
View File

@ -10,18 +10,16 @@
#include <linux/sched.h> #include <linux/sched.h>
static inline int dl_prio(int prio) static inline bool dl_prio(int prio)
{ {
if (unlikely(prio < MAX_DL_PRIO)) return unlikely(prio < MAX_DL_PRIO);
return 1;
return 0;
} }
/* /*
* Returns true if a task has a priority that belongs to DL class. PI-boosted * Returns true if a task has a priority that belongs to DL class. PI-boosted
* tasks will return true. Use dl_policy() to ignore PI-boosted tasks. * tasks will return true. Use dl_policy() to ignore PI-boosted tasks.
*/ */
static inline int dl_task(struct task_struct *p) static inline bool dl_task(struct task_struct *p)
{ {
return dl_prio(p->prio); return dl_prio(p->prio);
} }

16
include/linux/sched/rt.h
View File

@ -6,25 +6,21 @@
struct task_struct; struct task_struct;
static inline int rt_prio(int prio) static inline bool rt_prio(int prio)
{ {
if (unlikely(prio < MAX_RT_PRIO && prio >= MAX_DL_PRIO)) return unlikely(prio < MAX_RT_PRIO && prio >= MAX_DL_PRIO);
return 1;
return 0;
} }
static inline int realtime_prio(int prio) static inline bool realtime_prio(int prio)
{ {
if (unlikely(prio < MAX_RT_PRIO)) return unlikely(prio < MAX_RT_PRIO);
return 1;
return 0;
} }
/* /*
* Returns true if a task has a priority that belongs to RT class. PI-boosted * Returns true if a task has a priority that belongs to RT class. PI-boosted
* tasks will return true. Use rt_policy() to ignore PI-boosted tasks. * tasks will return true. Use rt_policy() to ignore PI-boosted tasks.
*/ */
static inline int rt_task(struct task_struct *p) static inline bool rt_task(struct task_struct *p)
{ {
return rt_prio(p->prio); return rt_prio(p->prio);
} }
@ -34,7 +30,7 @@ static inline int rt_task(struct task_struct *p)
* PI-boosted tasks will return true. Use realtime_task_policy() to ignore * PI-boosted tasks will return true. Use realtime_task_policy() to ignore
* PI-boosted tasks. * PI-boosted tasks.
*/ */
static inline int realtime_task(struct task_struct *p) static inline bool realtime_task(struct task_struct *p)
{ {
return realtime_prio(p->prio); return realtime_prio(p->prio);
} }