kevin/linux
1
Fork 0
Code

leds: pca9532: Simplify with scoped for each OF child loop

Browse Source 
Use scoped for_each_available_child_of_node_scoped() when iterating over
device nodes to make code a bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240816-cleanup-h-of-node-put-var-v1-14-1d0292802470@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>
This commit is contained in:
Krzysztof Kozlowski 2024-08-16 17:31:46 +02:00 committed by Lee Jones
parent d3f5f67405
commit af728722d7
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/leds/leds-pca9532.c
View File

@ -506,7 +506,6 @@ static struct pca9532_platform_data *
pca9532_of_populate_pdata(struct device *dev, struct device_node *np) pca9532_of_populate_pdata(struct device *dev, struct device_node *np)
{ {
struct pca9532_platform_data *pdata; struct pca9532_platform_data *pdata;
struct device_node *child;
int devid, maxleds; int devid, maxleds;
int i = 0; int i = 0;
const char *state; const char *state;
@ -525,7 +524,7 @@ pca9532_of_populate_pdata(struct device *dev, struct device_node *np)
of_property_read_u8_array(np, "nxp,psc", &pdata->psc[PCA9532_PWM_ID_0], of_property_read_u8_array(np, "nxp,psc", &pdata->psc[PCA9532_PWM_ID_0],
ARRAY_SIZE(pdata->psc)); ARRAY_SIZE(pdata->psc));
for_each_available_child_of_node(np, child) { for_each_available_child_of_node_scoped(np, child) {
if (of_property_read_string(child, "label", if (of_property_read_string(child, "label",
&pdata->leds[i].name)) &pdata->leds[i].name))
pdata->leds[i].name = child->name; pdata->leds[i].name = child->name;
@ -538,10 +537,8 @@ pca9532_of_populate_pdata(struct device *dev, struct device_node *np)
else if (!strcmp(state, "keep")) else if (!strcmp(state, "keep"))
pdata->leds[i].state = PCA9532_KEEP; pdata->leds[i].state = PCA9532_KEEP;
} }
if (++i >= maxleds) { if (++i >= maxleds)
of_node_put(child);
break; break;
}
} }
return pdata; return pdata;