kevin/linux
1
Fork 0
Code

serial: drop debugging WARN_ON_ONCE() from uart_write()

Browse Source 
syzbot is reporting lockdep warning upon

  int disc = 7;
  ioctl(open("/dev/ttyS3", O_RDONLY), TIOCSETD, &disc);

sequence. Do like what commit 5f1149d2f4 ("serial: drop debugging
WARN_ON_ONCE() from uart_put_char()") does.

Reported-by: syzbot+f78380e4eae53c64125c@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=f78380e4eae53c64125c
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Acked-by: Jiri Slaby <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/d775ae2d-a2ac-439e-8e2b-134749f60f30@I-love.SAKURA.ne.jp
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Tetsuo Handa 2024-05-29 00:05:53 +09:00 committed by Greg Kroah-Hartman
parent 7a2e8e30ad
commit ae01e52da2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/tty/serial/serial_core.c
View File

@ -622,7 +622,7 @@ static ssize_t uart_write(struct tty_struct *tty, const u8 *buf, size_t count)
return -EL3HLT; return -EL3HLT;
port = uart_port_lock(state, flags); port = uart_port_lock(state, flags);
if (WARN_ON_ONCE(!state->port.xmit_buf)) { if (!state->port.xmit_buf) {
uart_port_unlock(port, flags); uart_port_unlock(port, flags);
return 0; return 0;
} }