kevin/linux
1
Fork 0
Code

sysctl: Warn on an empty procname element

Browse Source 
Add a pr_err warning in case a ctl_table is registered with a sentinel
element containing a NULL procname.

Signed-off-by: Joel Granados <j.granados@samsung.com>
This commit is contained in:
Joel Granados 2024-06-04 08:29:26 +02:00
parent 3717540377
commit acc154691f
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/proc/proc_sysctl.c
View File

@ -1131,6 +1131,8 @@ static int sysctl_check_table(const char *path, struct ctl_table_header *header)
struct ctl_table *entry; struct ctl_table *entry;
int err = 0; int err = 0;
list_for_each_table_entry(entry, header) { list_for_each_table_entry(entry, header) {
if (!entry->procname)
err |= sysctl_err(path, entry, "procname is null");
if ((entry->proc_handler == proc_dostring) || if ((entry->proc_handler == proc_dostring) ||
(entry->proc_handler == proc_dobool) || (entry->proc_handler == proc_dobool) ||
(entry->proc_handler == proc_dointvec) || (entry->proc_handler == proc_dointvec) ||