kevin/linux
1
Fork 0
Code

btrfs: reduce size and overhead of extent_map_block_end()

Browse Source 
At extent_map_block_end() we are calling the inline functions
extent_map_block_start() and extent_map_block_len() multiple times, which
results in expanding their code multiple times, increasing the compiled
code size and repeating the computations those functions do.

Improve this by caching their results in local variables.

The size of the module before this change:

   $ size fs/btrfs/btrfs.ko
      text	   data	    bss	    dec	    hex	filename
   1755770	 163800	  16920	1936490	 1d8c6a	fs/btrfs/btrfs.ko

And after this change:

   $ size fs/btrfs/btrfs.ko
      text	   data	    bss	    dec	    hex	filename
   1755656	 163800	  16920	1936376	 1d8bf8	fs/btrfs/btrfs.ko

Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Filipe Manana 2024-07-23 15:21:22 +01:00 committed by David Sterba
parent 7fa5230b46
commit ab094670fa
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
fs/btrfs/extent_map.c
View File

@ -192,10 +192,13 @@ static inline u64 extent_map_block_len(const struct extent_map *em)
static inline u64 extent_map_block_end(const struct extent_map *em) static inline u64 extent_map_block_end(const struct extent_map *em)
{ {
if (extent_map_block_start(em) + extent_map_block_len(em) < const u64 block_start = extent_map_block_start(em);
extent_map_block_start(em)) const u64 block_end = block_start + extent_map_block_len(em);
if (block_end < block_start)
return (u64)-1; return (u64)-1;
return extent_map_block_start(em) + extent_map_block_len(em);
return block_end;
} }
static bool can_merge_extent_map(const struct extent_map *em) static bool can_merge_extent_map(const struct extent_map *em)