kevin/linux
1
Fork 0
Code

staging: vme_user: added bound check to geoid

Browse Source 
The geoid is a module parameter that allows users to hardcode the slot number.
A bound check for geoid was added in the probe function because only values
between 0 and less than VME_MAX_SLOT are valid.

Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20240827125604.42771-2-riyandhiman14@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Riyan Dhiman 2024-08-27 18:26:05 +05:30 committed by Greg Kroah-Hartman
parent c692c1b77b
commit a8a8b54350
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/staging/vme_user/vme_fake.c
View File

@ -1059,6 +1059,12 @@ static int __init fake_init(void)
struct vme_slave_resource *slave_image; struct vme_slave_resource *slave_image;
struct vme_lm_resource *lm; struct vme_lm_resource *lm;
if (geoid < 0 || geoid >= VME_MAX_SLOTS) {
pr_err("VME geographical address must be between 0 and %d (exclusive), but got %d\n",
VME_MAX_SLOTS, geoid);
return -EINVAL;
}
/* We need a fake parent device */ /* We need a fake parent device */
vme_root = root_device_register("vme"); vme_root = root_device_register("vme");
if (IS_ERR(vme_root)) if (IS_ERR(vme_root))

6
drivers/staging/vme_user/vme_tsi148.c
View File

@ -2252,6 +2252,12 @@ static int tsi148_probe(struct pci_dev *pdev, const struct pci_device_id *id)
struct vme_dma_resource *dma_ctrlr; struct vme_dma_resource *dma_ctrlr;
struct vme_lm_resource *lm; struct vme_lm_resource *lm;
if (geoid < 0 || geoid >= VME_MAX_SLOTS) {
dev_err(&pdev->dev, "VME geographical address must be between 0 and %d (exclusive), but got %d\n",
VME_MAX_SLOTS, geoid);
return -EINVAL;
}
/* If we want to support more than one of each bridge, we need to /* If we want to support more than one of each bridge, we need to
* dynamically generate this so we get one per device * dynamically generate this so we get one per device
*/ */