kevin/linux
1
Fork 0
Code

media: stm32: dcmipp: correct error handling in dcmipp_create_subdevs

Browse Source 
Correct error handling within the dcmipp_create_subdevs by properly
decrementing the i counter when releasing the subdevs.

Fixes: 28e0f37722 ("media: stm32-dcmipp: STM32 DCMIPP camera interface driver")
Cc: stable@vger.kernel.org
Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
[hverkuil: correct the indices: it's [i], not [i - 1].]
This commit is contained in:
Alain Volmat 2024-07-03 13:59:16 +02:00 committed by Hans Verkuil
parent 5d5f67b3b2
commit a7351f0d36
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
View File

@ -202,8 +202,8 @@ static int dcmipp_create_subdevs(struct dcmipp_device *dcmipp)
return 0;
err_init_entity:
while (i > 0)
dcmipp->pipe_cfg->ents[i - 1].release(dcmipp->entity[i - 1]);
while (i-- > 0)
dcmipp->pipe_cfg->ents[i].release(dcmipp->entity[i]);
return ret;
}