kevin/linux
1
Fork 0
Code

scripts/gdb: fix timerlist parsing issue

Browse Source 
Patch series "Fix some GDB command error and add some GDB commands", v3.

Fix some GDB command errors and add some useful GDB commands.


This patch (of 5):

Commit 7988e5ae2b ("tick: Split nohz and highres features from
nohz_mode") and commit 7988e5ae2b ("tick: Split nohz and highres
features from nohz_mode") move 'tick_stopped' and 'nohz_mode' to flags
field which will break the gdb lx-mounts command:

(gdb) lx-timerlist
Python Exception <class 'gdb.error'>: There is no member named nohz_mode.
Error occurred in Python: There is no member named nohz_mode.

(gdb) lx-timerlist
Python Exception <class 'gdb.error'>: There is no member named tick_stopped.
Error occurred in Python: There is no member named tick_stopped.

We move 'tick_stopped' and 'nohz_mode' to flags field instead.

Link: https://lkml.kernel.org/r/20240723064902.124154-1-kuan-ying.lee@canonical.com
Link: https://lkml.kernel.org/r/20240723064902.124154-2-kuan-ying.lee@canonical.com
Fixes: a478ffb2ae ("tick: Move individual bit features to debuggable mask accesses")
Fixes: 7988e5ae2b ("tick: Split nohz and highres features from nohz_mode")
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Kieran Bingham <kbingham@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Kuan-Ying Lee 2024-07-23 14:48:57 +08:00 committed by Andrew Morton
parent d1c7848b58
commit a633a4b800
1 changed files with 16 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
scripts/gdb/linux/timerlist.py
View File

@ -87,21 +87,22 @@ def print_cpu(hrtimer_bases, cpu, max_clock_bases):
text += "\n"
if constants.LX_CONFIG_TICK_ONESHOT:
fmts = [(" .{} : {}", 'nohz_mode'),
(" .{} : {} nsecs", 'last_tick'),
(" .{} : {}", 'tick_stopped'),
(" .{} : {}", 'idle_jiffies'),
(" .{} : {}", 'idle_calls'),
(" .{} : {}", 'idle_sleeps'),
(" .{} : {} nsecs", 'idle_entrytime'),
(" .{} : {} nsecs", 'idle_waketime'),
(" .{} : {} nsecs", 'idle_exittime'),
(" .{} : {} nsecs", 'idle_sleeptime'),
(" .{}: {} nsecs", 'iowait_sleeptime'),
(" .{} : {}", 'last_jiffies'),
(" .{} : {}", 'next_timer'),
(" .{} : {} nsecs", 'idle_expires')]
text += "\n".join([s.format(f, ts[f]) for s, f in fmts])
TS_FLAG_STOPPED = 1 << 1
TS_FLAG_NOHZ = 1 << 4
text += f" .{'nohz':15s}: {int(bool(ts['flags'] & TS_FLAG_NOHZ))}\n"
text += f" .{'last_tick':15s}: {ts['last_tick']}\n"
text += f" .{'tick_stopped':15s}: {int(bool(ts['flags'] & TS_FLAG_STOPPED))}\n"
text += f" .{'idle_jiffies':15s}: {ts['idle_jiffies']}\n"
text += f" .{'idle_calls':15s}: {ts['idle_calls']}\n"
text += f" .{'idle_sleeps':15s}: {ts['idle_sleeps']}\n"
text += f" .{'idle_entrytime':15s}: {ts['idle_entrytime']} nsecs\n"
text += f" .{'idle_waketime':15s}: {ts['idle_waketime']} nsecs\n"
text += f" .{'idle_exittime':15s}: {ts['idle_exittime']} nsecs\n"
text += f" .{'idle_sleeptime':15s}: {ts['idle_sleeptime']} nsecs\n"
text += f" .{'iowait_sleeptime':15s}: {ts['iowait_sleeptime']} nsecs\n"
text += f" .{'last_jiffies':15s}: {ts['last_jiffies']}\n"
text += f" .{'next_timer':15s}: {ts['next_timer']}\n"
text += f" .{'idle_expires':15s}: {ts['idle_expires']} nsecs\n"
text += "\njiffies: {}\n".format(jiffies)
text += "\n"