kevin/linux
1
Fork 0
Code

auxdisplay: hd44780: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
This commit is contained in:
Uwe Kleine-König 2024-03-11 22:59:23 +01:00 committed by Andy Shevchenko
parent 07d03559ed
commit 9ea02f7cc3
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/auxdisplay/hd44780.c
View File

@ -319,7 +319,7 @@ fail1:
return ret; return ret;
} }
static int hd44780_remove(struct platform_device *pdev) static void hd44780_remove(struct platform_device *pdev)
{ {
struct charlcd *lcd = platform_get_drvdata(pdev); struct charlcd *lcd = platform_get_drvdata(pdev);
struct hd44780_common *hdc = lcd->drvdata; struct hd44780_common *hdc = lcd->drvdata;
@ -329,7 +329,6 @@ static int hd44780_remove(struct platform_device *pdev)
kfree(lcd->drvdata); kfree(lcd->drvdata);
kfree(lcd); kfree(lcd);
return 0;
} }
static const struct of_device_id hd44780_of_match[] = { static const struct of_device_id hd44780_of_match[] = {
@ -340,7 +339,7 @@ MODULE_DEVICE_TABLE(of, hd44780_of_match);
static struct platform_driver hd44780_driver = { static struct platform_driver hd44780_driver = {
.probe = hd44780_probe, .probe = hd44780_probe,
.remove = hd44780_remove, .remove_new = hd44780_remove,
.driver = { .driver = {
.name = "hd44780", .name = "hd44780",
.of_match_table = hd44780_of_match, .of_match_table = hd44780_of_match,