kevin/linux
1
Fork 0
Code

vdpa/mlx5: Parallelize VQ suspend/resume for CVQ MQ command

Browse Source 
change_num_qps() is still suspending/resuming VQs one by one.
This change switches to parallel suspend/resume.

When increasing the number of queues the flow has changed a bit for
simplicity: the setup_vq() function will always be called before
resume_vqs(). If the VQ is initialized, setup_vq() will exit early. If
the VQ is not initialized, setup_vq() will create it and resume_vqs()
will resume it.

Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Message-Id: <20240816090159.1967650-11-dtatulea@nvidia.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Eugenio Pérez <eperezma@redhat.com>
Tested-by: Lei Yang <leiyang@redhat.com>
This commit is contained in:
Dragos Tatulea 2024-08-16 12:01:59 +03:00 committed by Michael S. Tsirkin
parent 74c89072f2
commit 9dba41951a
1 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
drivers/vdpa/mlx5/net/mlx5_vnet.c
View File

@ -2229,25 +2229,27 @@ static int change_num_qps(struct mlx5_vdpa_dev *mvdev, int newqps)
if (err) if (err)
return err; return err;
for (i = cur_vqs - 1; i >= new_vqs; i--) { if (is_resumable(ndev)) {
struct mlx5_vdpa_virtqueue *mvq = &ndev->vqs[i]; suspend_vqs(ndev, new_vqs, cur_vqs - new_vqs);
} else {
if (is_resumable(ndev)) for (i = new_vqs; i < cur_vqs; i++)
suspend_vq(ndev, mvq); teardown_vq(ndev, &ndev->vqs[i]);
else
teardown_vq(ndev, mvq);
} }
ndev->cur_num_vqs = new_vqs; ndev->cur_num_vqs = new_vqs;
} else { } else {
ndev->cur_num_vqs = new_vqs; ndev->cur_num_vqs = new_vqs;
for (i = cur_vqs; i < new_vqs; i++) {
struct mlx5_vdpa_virtqueue *mvq = &ndev->vqs[i];
err = mvq->initialized ? resume_vq(ndev, mvq) : setup_vq(ndev, mvq, true); for (i = cur_vqs; i < new_vqs; i++) {
err = setup_vq(ndev, &ndev->vqs[i], false);
if (err) if (err)
goto clean_added; goto clean_added;
} }
err = resume_vqs(ndev, cur_vqs, new_vqs - cur_vqs);
if (err)
goto clean_added;
err = modify_rqt(ndev, new_vqs); err = modify_rqt(ndev, new_vqs);
if (err) if (err)
goto clean_added; goto clean_added;