kevin/linux
1
Fork 0
Code

ipmi: kcs_bmc_npcm7xx: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Message-Id: <16144ffaa6f40a1a126d5cf19ef4337218a04fbb.1709655755.git.u.kleine-koenig@pengutronix.de>
Signed-off-by: Corey Minyard <minyard@acm.org>
This commit is contained in:
Uwe Kleine-König 2024-03-05 17:27:03 +01:00 committed by Corey Minyard
parent c61090f4ef
commit 999dff3c13
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/char/ipmi/kcs_bmc_npcm7xx.c
View File

@ -218,7 +218,7 @@ static int npcm7xx_kcs_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int npcm7xx_kcs_remove(struct platform_device *pdev) static void npcm7xx_kcs_remove(struct platform_device *pdev)
{ {
struct npcm7xx_kcs_bmc *priv = platform_get_drvdata(pdev); struct npcm7xx_kcs_bmc *priv = platform_get_drvdata(pdev);
struct kcs_bmc_device *kcs_bmc = &priv->kcs_bmc; struct kcs_bmc_device *kcs_bmc = &priv->kcs_bmc;
@ -227,8 +227,6 @@ static int npcm7xx_kcs_remove(struct platform_device *pdev)
npcm7xx_kcs_enable_channel(kcs_bmc, false); npcm7xx_kcs_enable_channel(kcs_bmc, false);
npcm7xx_kcs_irq_mask_update(kcs_bmc, (KCS_BMC_EVENT_TYPE_IBF | KCS_BMC_EVENT_TYPE_OBE), 0); npcm7xx_kcs_irq_mask_update(kcs_bmc, (KCS_BMC_EVENT_TYPE_IBF | KCS_BMC_EVENT_TYPE_OBE), 0);
return 0;
} }
static const struct of_device_id npcm_kcs_bmc_match[] = { static const struct of_device_id npcm_kcs_bmc_match[] = {
@ -243,7 +241,7 @@ static struct platform_driver npcm_kcs_bmc_driver = {
.of_match_table = npcm_kcs_bmc_match, .of_match_table = npcm_kcs_bmc_match,
}, },
.probe = npcm7xx_kcs_probe, .probe = npcm7xx_kcs_probe,
.remove = npcm7xx_kcs_remove, .remove_new = npcm7xx_kcs_remove,
}; };
module_platform_driver(npcm_kcs_bmc_driver); module_platform_driver(npcm_kcs_bmc_driver);